-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update locate-reuse-lib.js ui5 linter issues #2334
Conversation
🦋 Changeset detectedLatest commit: fe74f6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…s' into ui5_lint_issues_locate_reuse_libs * origin/ui5_lint_issues_locate_reuse_libs: fix: Dont update launch.json if app is not in workspace but launch config exists (#2333) chore: apply latest changesets fix(abap-deploy-config-inquirer): bug found with showing manual package prompt (#2325) chore: apply latest changesets fix(cpe): quick action titles (#2330)
…e_reuse_libs * origin/main: chore: apply latest changesets
Quality Gate passedIssues Measures |
…e_reuse_libs * origin/main: (217 commits) chore: apply latest changesets CPE - Add Custom Table Column Quick Action (#2469) chore: apply latest changesets TBI - UI5 FreeStyle template update best practice update for UI5 1.120.x (#2502) chore: apply latest changesets feat(ui5-info): update ui5 version fallbacks (#2501) chore: apply latest changesets feat: create page and table action quick actions for OData(v4) applications (#2483) chore: apply latest changesets fix(cpe): undo composite change (#2509) chore: apply latest changesets Fix: Zero State of Changes Panel (#2468) chore: apply latest changesets fix: add aria-label for UIFlexibleTable Add Row Button (#2507) chore: apply latest changesets Feat(preview middleware) add deep links to readme (#2481) add eslint warning for unsafe assignments (#2486) chore: apply latest changesets fix(ui-components): ignore asterisk for screen readers (#2503) chore: apply latest changesets ...
…e_reuse_libs * origin/main: chore: apply latest changesets fix(ui5-info): fix fallback logic for retrieving maintained versions (#2516) chore: apply latest changesets 2128/confirm prompt validator not invoked as expected (#2378) chore: apply latest changesets fix: Create Custom Table Column quick action bug fix (#2513) chore: apply latest changesets Fix: npm i after executing a create command fails on Windows (#2508)
…e_reuse_libs * origin/main: chore: apply latest changesets fix(store): no error message for denied keychain access (#2517)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- changeset ok
- PR description and changes match
- code adheres to coding standards
- didn't test locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates look good
Have not tested locally
Changeset
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good.
Test coverage is good
Changeset looks good.
* origin/main: fix fiori freestyle writer path issue (#2532) chore: apply latest changesets feat(ui-prompting): enhancement for translation input to provide annotation information of translation entry (#2448) chore: apply latest changesets Feature/2007/create cf deploy config writer (#2139) chore: apply latest changesets Update locate-reuse-lib.js ui5 linter issues (#2334)
#969
Support best practice UI5 1.120.x for
locate-reuse-lib.js
. Fixes errors when checked withnpx @ui5/linter
locate-reuse-lib.js
UX_DEBUG=true UX_DEBUG_FULL=true pnpm test