Revise launch config #2347
Merged
Revise launch config #2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2732943 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
broksy
previously approved these changes
Sep 11, 2024
|
@broksy @Klaus-Keller |
broksy
reviewed
Sep 17, 2024
broksy
reviewed
Sep 17, 2024
broksy
reviewed
Sep 17, 2024
broksy
reviewed
Sep 17, 2024
broksy
previously approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Hi @kjose90,
Please see some linting comments. Otherwise, code looks good.
…-tools into revise-launch-config
Klaus-Keller
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Thanks @kjose90!
- changes and revise launch config looks good
- change set exists
- code coverage is good
- did a visual review, no manual tests
Approved from my side.
broksy
approved these changes
Sep 19, 2024
|
Thanks everyone for reviewing |
|
tom-sap
added a commit
that referenced
this pull request
Sep 20, 2024
* main: chore: apply latest changesets feat(fpm-writer): property `allowAutoAddDependencyLib` to the building block API, which allows turning off the automatic addition of the 'sap.fe.macros' library (#2393) chore: apply latest changesets fix: missing unique react key (#2368) chore: apply latest changesets fix: theme picker hover and border for dropdowns (#2377) chore: apply latest changesets fix(preview-middleware): manifest changes not visible after reload (#2385) chore: apply latest changesets fix(ui-c): accessibility updates for uitable (#2391) chore: apply latest changesets Revise launch config (#2347) chore: apply latest changesets feat: app info file handling logic to new module @sap-ux/fiori-tools-settings (#2379)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mem-fsinstead to write launch config fileswriteApplicationInfoSettings()from@sap-ux/launch-configcreateLaunchConfig