Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security): update path-to-regex #2357

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

donal-tobin-sap
Copy link
Contributor

  • also related parent module express
  • and related module body parser
  • dependencies are dev only

Issue: tools-suite/issues/31259
Issue: https://github.com/SAP/open-ux-tools/security/dependabot/148
Issue: https://github.com/SAP/open-ux-tools/security/dependabot/149
Issue: https://github.com/SAP/open-ux-tools/security/dependabot/135

Copy link

changeset-bot bot commented Sep 11, 2024

⚠️ No Changeset found

Latest commit: 12095fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental test file change

IainSAP
IainSAP previously approved these changes Sep 11, 2024
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @donal-tobin-sap

  • Security updates as expected

longieirl
longieirl previously approved these changes Sep 11, 2024
Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump in version looks good.

- also related parent module express
- and related module body-parser
- dependencies are dev only
- removed test project file change
- second upgrade of express overnight
- and related module static-server
- and related module send

Issue: tools-suite/issues/31259
Issue: https://github.com/SAP/open-ux-tools/security/dependabot/148
Issue: https://github.com/SAP/open-ux-tools/security/dependabot/149
Issue: https://github.com/SAP/open-ux-tools/security/dependabot/135
Issue: https://github.com/SAP/open-ux-tools/security/dependabot/151
Issue: https://github.com/SAP/open-ux-tools/security/dependabot/150
@donal-tobin-sap
Copy link
Contributor Author

New express version and 2 more vulnerabilities fixed overnight

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security updates look good.

Copy link
Contributor

@Klaus-Keller Klaus-Keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version bump looks good.

Copy link

sonarcloud bot commented Sep 17, 2024

Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@donal-tobin-sap donal-tobin-sap merged commit b6a9bbb into main Sep 17, 2024
13 checks passed
@donal-tobin-sap donal-tobin-sap deleted the fix/31259/path-to-regexp-update branch September 17, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants