Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fe-fpm-writer): prompts: add building block questions into groups #2364

Merged
merged 10 commits into from
Sep 17, 2024

Conversation

AlinaGovoruhina
Copy link
Contributor

@AlinaGovoruhina AlinaGovoruhina commented Sep 13, 2024

Add groups with titles and descriptions to include existing building block prompts questions, add additional Manifest Change group.

From prompting-ui examples:
Chart
chart

Table
table

Filter Bar
filterBar

@AlinaGovoruhina AlinaGovoruhina requested a review from a team as a code owner September 13, 2024 11:07
Copy link

changeset-bot bot commented Sep 13, 2024

🦋 Changeset detected

Latest commit: 4a24c2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@sap-ux/fe-fpm-writer Minor
@sap-ux/prompting-ui Minor
@sap-ux/fiori-elements-writer Patch
@sap-ux/fe-fpm-cli Patch
@sap-ux/generator-simple-fe Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

815are
815are previously approved these changes Sep 16, 2024
Copy link
Contributor

@815are 815are left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked:

  1. code easy to read and did not notice issue
  2. changeset presented
  3. existing tests snapshots are adjusted

@hitesh-parmar
Copy link
Contributor

Thank you for the changes @AlinaGovoruhina.

Few changes are required 😀

Chart Building Block

Selection Change Function -> Selection Change Event
Placeholder -> Enter a function to be executed

Filter Bar Building Block

For both events, the placeholder should be changed from Enter a value to
Placeholder -> Enter a function to be executed

Copy link
Contributor

@hitesh-parmar hitesh-parmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text change addressed.
Tested ✅

Copy link

sonarcloud bot commented Sep 17, 2024

@AlinaGovoruhina AlinaGovoruhina merged commit 327ebec into main Sep 17, 2024
13 checks passed
@AlinaGovoruhina AlinaGovoruhina deleted the feat/fe-fpm-writer/bb-prompts-add-groups branch September 17, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants