-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fe-fpm-writer): prompts: add building block questions into groups #2364
feat(fe-fpm-writer): prompts: add building block questions into groups #2364
Conversation
🦋 Changeset detectedLatest commit: 4a24c2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked:
- code easy to read and did not notice issue
- changeset presented
- existing tests snapshots are adjusted
Thank you for the changes @AlinaGovoruhina. Few changes are required 😀 Chart Building Block Selection Change Function -> Selection Change Event Filter Bar Building Block For both events, the placeholder should be changed from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text change addressed.
Tested ✅
Quality Gate passedIssues Measures |
Add groups with titles and descriptions to include existing building block prompts questions, add additional Manifest Change group.
From prompting-ui examples:
Chart
Table
Filter Bar