feat(fe-fpm-writer): reuse 'async getManifest' function and make API methods async #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuse get manifest function and make api methods async
additional missed place
🦋 Changeset detectedLatest commit: d421fa1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
adjust integration tests
adjust consumer code
815are
changed the title
async getManifest function and make API methods async
815are
changed the title
async getManifest function and make API methods async…P/open-ux-tools into feat/reuseGetManifestFunction
missed todo
815are
force-pushed
the
feat/reuseGetManifestFunction
branch
from
d73cf39
to
211d838
Compare
|
AlinaGovoruhina
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up after -> #2348
where we started to use function
getWebappPathfrom@sap-ux/project-access.Such change required to make API methods
async.In this PR - I continued with all other API calls ->
getManifestorgetManifestPathfunction;asyncAddition change:
@sap-ux/fiori-elements-writer-> call 'generateCustomPage' from 'fe-fpm-writer' as async function