Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cpe): fixed warnings and type issues in tests #2369

Merged
merged 8 commits into from
Sep 18, 2024

Conversation

voicis
Copy link
Contributor

@voicis voicis commented Sep 13, 2024

#2220

  • Fixed typescript compiler errors in tests
  • Cleaned up a bit change types
  • Added default setup code for all tests (i18n, icons); this no longer needs to be done in each of the tests files
  • Changed that typescript compile errors will break control-property-editor build
  • Fixed various lint errors

@voicis voicis added the control-property-editor @sap-ux/control-property-editor label Sep 13, 2024
@voicis voicis requested review from a team as code owners September 13, 2024 18:48
Copy link

changeset-bot bot commented Sep 13, 2024

⚠️ No Changeset found

Latest commit: 6cb3210

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nikmace nikmace self-requested a review September 17, 2024 13:16
Copy link

sonarcloud bot commented Sep 18, 2024

Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good
Coverage is good
Did not test manually

Copy link
Contributor

@Jimmy-Joseph19 Jimmy-Joseph19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring.
Overall Changes looks fine.
Test coverage good.
Did not test locally
Approving

@voicis voicis merged commit 122aebf into main Sep 18, 2024
13 checks passed
@voicis voicis deleted the refactor/2220/fix-tests branch September 18, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
control-property-editor @sap-ux/control-property-editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants