Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(@sap-ux/odata service inquirer): Adds system selection prompting #2374

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat(@sap-ux/odata service inquirer): Adds system selection prompting #2374

wants to merge 3 commits into from

Conversation

IainSAP
Copy link
Contributor

@IainSAP IainSAP commented Sep 16, 2024

#2373

  • Adds system selection prompt for VSCode

todo:

  • Adds system selection for destinations (BAS)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2024

⚠️ No Changeset found

Latest commit: f35d17f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@IainSAP IainSAP changed the title Feat(odata service inquirer)/2373/adds system prompt from store Feat(odata service inquirer): Adds system selection prompting Sep 16, 2024
@IainSAP IainSAP changed the title Feat(odata service inquirer): Adds system selection prompting feat(@sap-ux/odata service inquirer): Adds system selection prompting Sep 16, 2024
IainSAP
IainSAP commented Sep 16, 2024
View reviewed changes
packages/odata-service-inquirer/jest.config.js
@@ -4,4 +4,5 @@ config.snapshotFormat = {
escapeString: false,
printBasicPrototype: false
};
config.collectCoverage = false;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

@IainSAP IainSAP self-assigned this Sep 16, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@IainSAP IainSAP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@IainSAP