2128/confirm prompt validator not invoked as expected

[longieirl]

Fix for #2128

• The confirm SCP prompt has a validator method attached which is not invoked for all flows i.e. CLI and YUI, refer to inquirer API. However, the abap-inq was written as if this validator was invoked for both YUI and CLI. This PR removes the validator method and ensures the scp prompt state is maintained correctly by adding a scp setter prompt to handle both flows, CLI and YUI.
• If the user selects a SAP system, the client prompt will no longer be shown, this causes issues with the connectivity flow if the user tries to switch client ID's as then the saved system properties will not be used
• Tests added
• Validated locally on VSC and on BAS

Example1;

ui5.yaml

        backend:
          - scp: true
            path: /sap
            url: https://example.ondemand.com

Prompts;

Adding deploy-config to the project.
info Add:Deploy-config Using: @sap/fiori:deploy-config
? Select Target system abap-05 (BTP) [tester@example]
? SAPUI5 ABAP Repository (ZTEST) 

Example2;

ui5.yaml

        backend:
          - scp: false
            path: /sap
            url: https://example.ondemand.com
            client: 300

Prompts;

Adding deploy-config to the project.
info Add:Deploy-config Using: @sap/fiori:deploy-config
? Select Target system abap-05 (BTP) [[email protected]]
? SAPUI5 ABAP Repository (ZTEST) 

Example3;

Prompts;

info Add:Deploy-config Using: @sap/fiori:deploy-config
? Select Target system Enter Target System URL
? Target System URL https://example.net.sap:44300
? Is this an SAP Business Technology Platform system? Yes
? SAPUI5 ABAP Repository (ZTEST) 

Example4;

info Add:Deploy-config Using: @sap/fiori:deploy-config
? Select Target system Enter Target System URL
? Target System URL https://example.net.sap:44300
? Is this an SAP Business Technology Platform system? No
? Client (Use arrow keys)
❯ Use project defined client 300 
  Enter client 
  Use default system client 

Example5;

info Add:Deploy-config Using: @sap/fiori:deploy-config
? Select Target system Enter Target System URL
? Target System URL https://example.devint.net.sap:44300
? Is this an SAP Business Technology Platform system? No
? Enter client 

[changeset-bot]

🦋 Changeset detected

Latest commit: d145a2d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@sap-ux/abap-deploy-config-inquirer	Patch
@sap-ux/create	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[cianmSAP]

Update looks good
Not manually tested
Tests to cover
Changeset ✅

[cianmSAP]

Re-approving

[IainSAP]

Thanks @longieirl

• Understandability of the client prompt condition could be clearer but defer to the author
• Tests updated

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud