Refactor shared logic for generating package.json scripts for FF and FE #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2e8cf5e The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…x-tools into package-config-common
devinea
previously approved these changes
Sep 24, 2024
IainSAP
reviewed
Sep 24, 2024
…x-tools into package-config-common
|
devinea
added a commit
that referenced
this pull request
Sep 30, 2024
…on-CAP-Fiori-generation-into-a-CAP-project-folder * origin/main: chore: apply latest changesets feat(ui-prompting): rename ui prompting examples package from `@sap-ux/prompting-ui` to `@sap-ux-private/ui-prompting-examples` (#2415) chore: apply latest changesets fix: adjust condition for dynamic header field content (#2412) chore: apply latest changesets feat(ui-prompting): support translation input fields for prompts (#2400) chore: apply latest changesets Renamed the skipLiveScript parameter to addLiveConfig (#2405) chore: apply latest changesets fix: various ui improvements and bug fix (#2410) chore: apply latest changesets Refactor shared logic for generating package.json scripts for FF and FE (#2386) chore: apply latest changesets feat: enhance quick action with the template (#2388) chore: apply latest changesets fix(cpe): application mode after reload (#2389)
emrecevik06
pushed a commit
that referenced
this pull request
Oct 11, 2024
…FE (#2386) * refactoring shared logic for adding package json scriots for FF and FE * add changeset * add docs * pnpm recursive install * revert translations mockOnlyWarning * fix sonar issues * resolving conflictas after merge * revise export of function * change name to getPackageScripts * fix test name * test fix * add lint ignore escape chars * add lint ignore escape chars * es lint * add a comment explaining not to remove escape chars from command --------- Co-authored-by: Austin Devine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2320
package.jsonscripts intofiori-generator-shared, ensuring that both Fiori Elements and Freestyle applications use a common, reusable implementation.