Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uitable a11y2 #2396

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Uitable a11y2 #2396

merged 5 commits into from
Sep 20, 2024

Conversation

tom-sap
Copy link
Contributor

@tom-sap tom-sap commented Sep 20, 2024

follow up from #2391
(git merge went wrong)

The :focus style should have been added to the column header cells (not to the header row).

* main:
  chore: apply latest changesets
  feat(fpm-writer): property `allowAutoAddDependencyLib` to the building block API, which allows turning off the automatic addition of the 'sap.fe.macros' library (#2393)
  chore: apply latest changesets
  fix: missing unique react key (#2368)
  chore: apply latest changesets
  fix: theme picker hover and border for dropdowns (#2377)
  chore: apply latest changesets
  fix(preview-middleware): manifest changes not visible after reload (#2385)
  chore: apply latest changesets
  fix(ui-c): accessibility updates for uitable (#2391)
  chore: apply latest changesets
  Revise launch config  (#2347)
  chore: apply latest changesets
  feat: app info file handling logic to new module @sap-ux/fiori-tools-settings (#2379)
@tom-sap tom-sap requested a review from a team as a code owner September 20, 2024 10:32
Copy link

changeset-bot bot commented Sep 20, 2024

🦋 Changeset detected

Latest commit: 42e6c24

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux/ui-components Patch
@sap-ux/ui-prompting Patch
@sap-ux/prompting-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@815are 815are left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked:

  1. style update - did not notice issue
  2. changeset is presented

Copy link

sonarcloud bot commented Sep 20, 2024

@tom-sap tom-sap merged commit 89ec1c3 into main Sep 20, 2024
13 checks passed
@tom-sap tom-sap deleted the uitable-a11y2 branch September 20, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants