Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes ampersand escaping #2399

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Fixes ampersand escaping #2399

merged 4 commits into from
Sep 20, 2024

Conversation

IainSAP
Copy link
Contributor

@IainSAP IainSAP commented Sep 20, 2024

Fix for #2397

  • Correctly escapes and assigns result
  • Adds test to cover

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 014bfbf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/odata-service-inquirer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@IainSAP IainSAP requested a review from voicis September 20, 2024 12:58
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

voicis
voicis approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Change looks good
  • Good test coverage
  • Changeset present
  • Did not test, just inspected the code

devinea
devinea approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes are clear and covered by test.
changeset ✅

@IainSAP IainSAP merged commit b4b3ebe into main Sep 20, 2024
13 checks passed
@IainSAP IainSAP deleted the fix/2397/ampersand_escaping_metadata branch September 20, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinea devinea devinea approved these changes

@voicis voicis voicis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IainSAP @voicis @devinea