Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fiori-gen): add telemetry helper class and associated functions #2489

Merged
merged 19 commits into from
Oct 25, 2024
Merged

feat(fiori-gen): add telemetry helper class and associated functions #2489

merged 19 commits into from
Oct 25, 2024

Conversation

cianmSAP
Copy link
Contributor

@cianmSAP cianmSAP commented Oct 23, 2024 •
edited
Loading

#2472

Adds some common utilities to @sap-ux/fiori-generator-shared in prerparation for the reference library generator

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: d1d7fcc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@sap-ux/fiori-generator-shared Minor
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/cap-config-writer Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/ui5-library-sub-generator Patch
@sap-ux/create Patch
@sap-ux/generator-simple-fe Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cianmSAP cianmSAP changed the title feat(fiori-gen): add common utilities feat(fiori-gen): add telemtry helper class and associated functions Oct 24, 2024
@cianmSAP cianmSAP changed the title feat(fiori-gen): add telemtry helper class and associated functions feat(fiori-gen): add telemetry helper class and associated functions Oct 24, 2024
@cianmSAP cianmSAP requested a review from IainSAP October 24, 2024 17:02
longieirl
longieirl approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments addressed.
Code changes look good.
Tests and changeset looks good.

IainSAP
IainSAP approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cianmSAP

  • Comments address
  • Test cover new code

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cianmSAP cianmSAP merged commit 231e713 into main Oct 25, 2024
13 checks passed
@cianmSAP cianmSAP deleted the feat/ref-lib/2472-ref-lib-prep branch October 25, 2024 17:37
devinea added a commit that referenced this pull request Oct 25, 2024
@devinea
Merge remote-tracking branch 'origin/main' into ui5-2.0-FF_template-u…
49e34f2 
…pdate

* origin/main:
  chore: apply latest changesets
  feat(fiori-gen): add telemetry helper class and associated functions (#2489)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IainSAP IainSAP IainSAP approved these changes

@longieirl longieirl longieirl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cianmSAP @longieirl @IainSAP