Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable quick actions #2534

Merged
merged 16 commits into from
Nov 13, 2024
Merged

chore: enable quick actions #2534

merged 16 commits into from
Nov 13, 2024

Conversation

voicis
Copy link
Contributor

@voicis voicis commented Nov 6, 2024

Remove feature flag check for "Add Custom Table Action", "Add Custom Page Action", "Add Custom Table Column" and "Change Table Columns" Quick Actions.

Copy link

changeset-bot bot commented Nov 6, 2024

🦋 Changeset detected

Latest commit: 0893a4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux-private/preview-middleware-client Patch
@sap-ux/preview-middleware Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nikmace
nikmace previously approved these changes Nov 8, 2024
Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good
Tests adjusted and coverage is excellent
Did not test manually

@voicis
Copy link
Contributor Author

voicis commented Nov 12, 2024

The duplicate code check does not seem to be entirely accurate here, because it is complaining about the same variable names, even though they are imported from different files and entirely different code is referenced.

@voicis voicis requested a review from nikmace November 12, 2024 12:08
Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving, changes look good
Coverage is 100%, although Sonar as failing (false positive)
Did not test manually

Copy link
Contributor

@vadson71 vadson71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are straightforward
Good test coverage
Didn't test locally

Copy link

sonarcloud bot commented Nov 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@devinea devinea merged commit fcc5518 into main Nov 13, 2024
12 of 13 checks passed
@devinea devinea deleted the chore/cpe/enable-quick-actions branch November 13, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants