Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unavailability of changeHandlerAPI in lower ui5 version causes console to be spammed with errors #2537

Merged
merged 7 commits into from
Nov 11, 2024

Conversation

nikmace
Copy link
Contributor

@nikmace nikmace commented Nov 6, 2024

Fix for #2521.

  • prepareChangeType failing for updateVariant command because getPreparedChange does not exist on BaseCommand.
  • changes logging errors in retryOperations method into a single log
  • check if changeHandlerAPI.getChangeHandler exists in lower versions (i.e UI5 Version '1.84.47')

@nikmace nikmace requested a review from a team November 6, 2024 17:15
@nikmace nikmace requested a review from a team as a code owner November 6, 2024 17:15
Copy link

changeset-bot bot commented Nov 6, 2024

🦋 Changeset detected

Latest commit: 7e62a0e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux-private/preview-middleware-client Patch
@sap-ux/preview-middleware Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@mmilko01 mmilko01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good.
Changeset looks good.
Excellent test coverage.
Did not test manually.

Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changes looks good
  • Good test coverage
  • Tested locally (no more error messages in the console when properties are updated)

Copy link

sonarcloud bot commented Nov 11, 2024

@nikmace nikmace merged commit 838cdf1 into main Nov 11, 2024
13 checks passed
@nikmace nikmace deleted the fix/2521/console-spam branch November 11, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants