Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2702/expose new btp destination creation flow #2760

Closed
wants to merge 11 commits into from

Conversation

longieirl
Copy link
Contributor

Fix for #2702

  • changes applied to btp-utils
  • leverage cf-tools to obtain UAA credentials, used to generate a new OAuth2TokenExchange BTP destination
  • changes validated on BAS

Note:

  • There is no exception thrown if the destination is already created on the target subaccount
  • Exception thrown if the user is not logged into cf
  • Exception thrown if subaccount doesn't have a dev space created
  • If the SAP BTP destination already exists, existing properties are not updated if already present on the target destination

@longieirl longieirl self-assigned this Jan 9, 2025
Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: 0a92aee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@sap-ux/btp-utils Minor
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/adp-tooling Patch
@sap-ux/app-config-writer Patch
@sap-ux/axios-extension Patch
@sap-ux/backend-proxy-middleware Patch
@sap-ux/cf-deploy-config-inquirer Patch
@sap-ux/cf-deploy-config-writer Patch
@sap-ux/deploy-config-generator-shared Patch
@sap-ux/deploy-tooling Patch
@sap-ux/environment-check Patch
@sap-ux/fiori-generator-shared Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/inquirer-common Patch
@sap-ux/nodejs-utils Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/preview-middleware Patch
@sap-ux/reload-middleware Patch
@sap-ux/system-access Patch
@sap-ux/telemetry Patch
@sap-ux/odata-cli Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/create Patch
@sap-ux/flp-config-sub-generator Patch
@sap-ux/cap-config-writer Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/ui5-library-reference-sub-generator Patch
@sap-ux/ui5-library-sub-generator Patch
@sap-ux/ui5-application-inquirer Patch
@sap-ux/ui5-library-inquirer Patch
@sap-ux/ui5-library-reference-inquirer Patch
@sap-ux/abap-deploy-config-writer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@longieirl longieirl marked this pull request as ready for review January 9, 2025 20:51
cianmSAP
cianmSAP previously approved these changes Jan 10, 2025
Copy link
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests indicate new functionality clearly
Excellent test coverage
Would this new functionality not warrant a minor version bump?

@longieirl
Copy link
Contributor Author

Thanks @cianmSAP updated to minor, good catch.

@longieirl longieirl requested a review from cianmSAP January 10, 2025 11:15
@longieirl
Copy link
Contributor Author

Closing this PR, changes made to @sap/bas-sdk now reflect this flow.

@longieirl longieirl closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants