refactor: inline quote role service (CXSPA-4763) (#17864)

feature-libs/quote/components/quote-actions-by-role/quote-actions-by-role.component.spec.ts

@@ -11,6 +11,7 @@ import {
   QuoteAction,
   QuoteActionType,
   QuoteFacade,
+  QuoteRoleType,
   QuoteState,
 } from '@spartacus/quote/root';
 
@@ -586,4 +587,29 @@ describe('QuoteActionsByRoleComponent', () => {
       ).toEqual('btn-tertiary');
     });
   });
+
+  describe('stateToRoleTypeForDialogConfig', () => {
+    it('should return buyer-role', () => {
+      expect(
+        component['stateToRoleTypeForDialogConfig'](QuoteState.BUYER_DRAFT)
+      ).toBe(QuoteRoleType.BUYER);
+    });
+    it('should return seller-role', () => {
+      expect(
+        component['stateToRoleTypeForDialogConfig'](QuoteState.SELLER_SUBMITTED)
+      ).toBe(QuoteRoleType.SELLER);
+    });
+    it('should return seller-approver-role', () => {
+      expect(
+        component['stateToRoleTypeForDialogConfig'](
+          QuoteState.SELLERAPPROVER_APPROVED
+        )
+      ).toBe(QuoteRoleType.SELLERAPPROVER);
+    });
+    it('should return default (not_available) role type if no role matches', () => {
+      expect(
+        component['stateToRoleTypeForDialogConfig'](QuoteState.CANCELLED)
+      ).toBe(QuoteRoleType.NOT_AVAILABLE);
+    });
+  });
 });

feature-libs/quote/components/quote-actions-by-role/quote-actions-by-role.component.ts

@@ -13,12 +13,12 @@ import {
   ViewContainerRef,
 } from '@angular/core';
 import { GlobalMessageService, GlobalMessageType } from '@spartacus/core';
-import { QuoteRoleService } from '@spartacus/quote/core';
 import {
   Quote,
   QuoteAction,
   QuoteActionType,
   QuoteFacade,
+  QuoteRoleType,
   QuoteState,
 } from '@spartacus/quote/root';
 import { LAUNCH_CALLER, LaunchDialogService } from '@spartacus/storefront';
@@ -46,7 +46,6 @@ export class QuoteActionsByRoleComponent implements OnInit, OnDestroy {
     protected launchDialogService: LaunchDialogService,
     protected viewContainerRef: ViewContainerRef,
     protected globalMessageService: GlobalMessageService,
-    protected quoteRoleService: QuoteRoleService,
     protected config: QuoteUIConfig
   ) {}
 
@@ -164,7 +163,7 @@ export class QuoteActionsByRoleComponent implements OnInit, OnDestroy {
     const mappingConfig = this.config.quote?.confirmActionDialogMapping;
     return (
       !!mappingConfig?.[state]?.[action] ||
-      !!mappingConfig?.[this.quoteRoleService.stateToRole(state)]?.[action]
+      !!mappingConfig?.[this.stateToRoleTypeForDialogConfig(state)]?.[action]
     );
   }
 
@@ -199,7 +198,7 @@ export class QuoteActionsByRoleComponent implements OnInit, OnDestroy {
 
     const config =
       mappingConfig?.[state]?.[action] ??
-      mappingConfig?.[this.quoteRoleService.stateToRole(state)]?.[action];
+      mappingConfig?.[this.stateToRoleTypeForDialogConfig(state)]?.[action];
     if (!config) {
       throw new Error(
         `Dialog Config expected for quote in state ${state} and action ${action}, but none found in config ${mappingConfig}`
@@ -208,4 +207,14 @@ export class QuoteActionsByRoleComponent implements OnInit, OnDestroy {
 
     return config;
   }
+
+  protected stateToRoleTypeForDialogConfig(state: QuoteState): QuoteRoleType {
+    let foundRole: QuoteRoleType = QuoteRoleType.NOT_AVAILABLE;
+    Object.values(QuoteRoleType).forEach((role) => {
+      if (state.startsWith(role + '_')) {
+        foundRole = role;
+      }
+    });
+    return foundRole;
+  }
 }

feature-libs/quote/core/services/index.ts

@@ -5,4 +5,3 @@
  */
 
 export * from './cart-utils.service';
-export * from './quote-role.service';