chore: fix sonar issues

SAP · May 11, 2023 · 866ca82 · 866ca82
1 parent c78b1fc
commit 866ca82
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/feature-libs/cart/base/core/cart-persistence.module.ts b/feature-libs/cart/base/core/cart-persistence.module.ts
@@ -20,15 +20,14 @@ export function cartStatePersistenceFactory(
   cartStatePersistenceService: MultiCartStatePersistenceService,
   configInit: ConfigInitializerService
 ): () => Promise<Config> {
-  const result = () =>
+  return () =>
     lastValueFrom(
       configInit.getStable('context').pipe(
         tap(() => {
           cartStatePersistenceService.initSync();
         })
       )
     );
-  return result;
 }
 
 /**

diff --git a/integration-libs/cdc/root/cdc-root.module.ts b/integration-libs/cdc/root/cdc-root.module.ts
@@ -24,15 +24,14 @@ export function cdcJsFactory(
   cdcJsService: CdcJsService,
   configInit: ConfigInitializerService
 ): () => Promise<Config> {
-  const func = () =>
+  return () =>
     lastValueFrom(
       configInit.getStable('context', 'cdc').pipe(
         tap(() => {
           cdcJsService.initialize();
         })
       )
     );
-  return func;
 }
 
 export function defaultCdcComponentsConfig(): CmsConfig {

diff --git a/...ation-libs/cdc/user-profile/update-password/cdc-update-password-component.service.spec.ts b/...ation-libs/cdc/user-profile/update-password/cdc-update-password-component.service.spec.ts
@@ -129,7 +129,10 @@ describe('CDCUpdatePasswordComponentService', () => {
       beforeEach(() => {
         cdcJsService.updateUserPasswordWithoutScreenSet =
           createSpy().and.returnValue(
-            throwError({ status: 'ERROR', errorDetails: 'Error occured' })
+            throwError(() => ({
+              status: 'ERROR',
+              errorDetails: 'Error occured',
+            }))
           );
         TestBed.compileComponents();
       });