refactor: move quote related i18n props to quote lib (#17939)

SAP · Oct 9, 2023 · b694bbe · b694bbe
1 parent 70e3302
commit b694bbe
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 12 deletions.
diff --git a/feature-libs/quote/assets/translations/en/quote.i18n.ts b/feature-libs/quote/assets/translations/en/quote.i18n.ts
@@ -150,6 +150,8 @@ export const quote = {
       sortBy: 'Sort by',
       sortOrders: 'Sort orders',
       empty: 'We have no quote records for this account.',
+      quoteId: 'Quote ID',
+      status: 'Status',
     },
     states: {
       BUYER_DRAFT: 'Draft',

diff --git a/feature-libs/quote/components/list/quote-list-component.service.spec.ts b/feature-libs/quote/components/list/quote-list-component.service.spec.ts
@@ -104,9 +104,9 @@ describe('QuoteListComponentService', () => {
     //given
     const labels: { [key: string]: string } = {
       byDate: 'sorting.date',
-      byCode: 'sorting.quoteId',
-      byName: 'sorting.name',
-      byState: 'sorting.status',
+      byCode: 'quote.list.quoteId',
+      byName: 'quote.list.name',
+      byState: 'quote.list.status',
     };
 
     //then

diff --git a/feature-libs/quote/components/list/quote-list-component.service.ts b/feature-libs/quote/components/list/quote-list-component.service.ts
@@ -41,9 +41,9 @@ export class QuoteListComponentService {
 
   sortLabels$: Observable<{ [key: string]: string }> = combineLatest([
     this.translationService.translate('sorting.date'),
-    this.translationService.translate('sorting.quoteId'),
-    this.translationService.translate('sorting.name'),
-    this.translationService.translate('sorting.status'),
+    this.translationService.translate('quote.list.quoteId'),
+    this.translationService.translate('quote.list.name'),
+    this.translationService.translate('quote.list.status'),
   ]).pipe(
     map(
       ([

diff --git a/feature-libs/quote/components/list/quote-list.component.spec.ts b/feature-libs/quote/components/list/quote-list.component.spec.ts
@@ -104,9 +104,9 @@ class MockCommerceQuotesListComponentService
   sorts?: SortModel[] | undefined = mockSorts;
   sortLabels$ = of({
     byDate: 'sorting.date',
-    byCode: 'sorting.quoteId',
-    byName: 'sorting.name',
-    byState: 'sorting.status',
+    byCode: 'quote.list.quoteId',
+    byName: 'quote.list.name',
+    byState: 'quote.list.status',
   });
   quotesState$ = mockQuoteListState$.asObservable();
   sort = new BehaviorSubject('byCode');

diff --git a/projects/assets/src/translations/en/common.ts b/projects/assets/src/translations/en/common.ts
@@ -89,9 +89,6 @@ export const common = {
     rma: 'Return Number',
     replenishmentNumber: 'Replenishment Number',
     nextOrderDate: 'Next Order Date',
-    quoteId: 'Quote ID',
-    name: 'Name',
-    status: 'Status',
     pageViewUpdated: 'Page view updated with your selected options.',
   },
   httpHandlers: {