Skip to content

Commit

Permalink
chore: update CI to use node 18 (#17842)
Browse files Browse the repository at this point in the history
chore: update the CI to use node 18

closes: https://jira.tools.sap/browse/CXSPA-4599
  • Loading branch information
RadhepS authored Sep 19, 2023
1 parent 9dcb262 commit c933a6c
Show file tree
Hide file tree
Showing 9 changed files with 10 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/cache-node-modules.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
name: Cache node modules

env:
NODE_VERSION: '16'
NODE_VERSION: '18'

jobs:
cacheNodeModules:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
# empty as it is used only to manually trigger the workflow

env:
NODE_VERSION: '16'
NODE_VERSION: '18'
NX_BASE: origin/${{ github.event.pull_request.base.ref }}
NX_HEAD: origin/${{ github.event.pull_request.head.ref }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-merge-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
env:
CYPRESS_KEY: ${{ secrets.CYPRESS_KEY }}
GH_TOKEN: ${{ github.token }}
NODE_VERSION: '16'
NODE_VERSION: '18'

concurrency:
group: ci-merge-checks-${{ github.head_ref || github.run_id }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:

env:
CYPRESS_KEY: ${{ secrets.CYPRESS_KEY }}
NODE_VERSION: '16'
NODE_VERSION: '18'

concurrency:
group: ci-${{ github.head_ref || github.run_id }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lighthouse.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
# empty as it is used only to manually trigger the workflow
env:
CYPRESS_KEY: ${{ secrets.CYPRESS_KEY }}
NODE_VERSION: '16'
NODE_VERSION: '18'

concurrency:
group: lighthouse-${{ github.head_ref || github.run_id }}
Expand Down
2 changes: 2 additions & 0 deletions ci-scripts/e2e-cypress.sh
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ fi
echo '-----'
echo "Building Spartacus libraries"

export NODE_OPTIONS=--dns-result-order=ipv4first

npm ci

(cd projects/storefrontapp-e2e-cypress && npm ci)
Expand Down
1 change: 1 addition & 0 deletions ci-scripts/lhci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
set -e

export SPA_ENV='lighthouse'
export NODE_OPTIONS=--dns-result-order=ipv4first

npm install -g @lhci/[email protected]

Expand Down
2 changes: 1 addition & 1 deletion projects/schematics/src/dependencies.json
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,6 @@
"rxjs": "^6.6.0",
"ts-loader": "^9.4.4",
"tslib": "^2.6.2",
"zone.js": "~0.11.8"
"zone.js": "~0.12.0"
}
}
2 changes: 1 addition & 1 deletion tools/config/const.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ export const SPARTACUS_SCOPE = '@spartacus';
export const SAP_SCOPE = 'sap';
export const SAPUI5_TYPES = '@sapui5/ts-types-esm';
export const SPARTACUS_SCHEMATICS = `${SPARTACUS_SCOPE}/schematics`;
export const PUBLISHING_VERSION = '6.3.0-1';
export const PUBLISHING_VERSION = '';

0 comments on commit c933a6c

Please sign in to comment.