feat: CXINT-1850: Requested Delivery Date feature library

[SherwinVarghese]

Requested Delivery Date

Requested Delivery Date allows customers to provide a delivery date for which the item would be needed. The minimum date would be fetched from the S/4 HANA system and used along with the Order.

Screenshots of features

Checkout

Delivery Mode Selection

Checkout Review

Order Confirmation

Order History

E2E Cypress Tests

Epic Release Checklist

General

• Epic has been tested on a production-like server using Spartacus installation script
• Epic has been tested in all supported browsers and devices (Check list on DoD page)
• Epic has sufficient end to end (cypress) test coverage
• Schematics code deprecations have been provided and tested
• Epic complies with Security best practices
• Epic complies with Accessibility best practices
• Epic CSS supports directionality (if required)
• Epic code scans have been conducted Compliance scans for branches
• Epic renders successfully in SSR

Audits/reviews

• Architecture review of the epic
• Security and threat modeling audit/review from the Security team
• Accessibility audit/review from the UX team

New Library

If your epic will be introduced or introduces a new library:

• Library provides schematics to install the library
• Library modules can be lazy loaded appropriately
• Library has been tested for a customer using Spartacus installation script

Sample data (Not Applicable)

If the new feature requires new or updated sample data for a specific Commerce backend version: [N/A]

• Sample data has been added to the sampledata repo and merged to the next version to be released
• New sample data has been loaded and tested on a dev server
• New sample data has been loaded and tested in our CI server

Documentation

• Documentation input is provided for it to be published on the doc site.

[cla-assistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ SherwinVarghese
✅ Matejk00
❌ github-actions[bot]
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[ChristophHi]

@SherwinVarghese Why is that a feature lib on its own? Isn't that just a new attribute that is provided in the S/4 integration scenario?

[SherwinVarghese]

@SherwinVarghese Why is that a feature lib on its own? Isn't that just a new attribute that is provided in the S/4 integration scenario?

Hi @ChristophHi,

This feature is designed to be independent of S/4 HANA integration scenario, and the OCC APIs are a part of the commercewebservices extension for SAP Commerce Cloud.

Accordingly, this library is added as a feature library.

[ChristophHi]

@SherwinVarghese Thanks for that explanation...but then why can't we put it into the checkout or order library? We don't have feature libs for the different checkout facets either. I just think creating libs for single fields is a bit overhead (unless I miss a specific point here). @Platonn What is your opinion?

[SherwinVarghese]

@ChristophHi,

I would agree with you, this will greatly reduce the number of files being added for this feature.
But as per the initial design discussion with @Xymmer, it was decided not to touch the core files directly, and to introduce a new feature library.

We can further discuss on what best is suited for this feature.

[cypress]

4 flaky tests on run #41228 ↗︎

0

119

2

0

4

Details:

Merge 83577f5 into 9df9704...
Project: spartacus	Commit: 3949dbfd37 ℹ️
Status: Passed	Duration: 07:37 💡
Started: Aug 10, 2023 7:40 AM	Ended: Aug 10, 2023 7:47 AM

  regression/checkout/checkout-flow.core-e2e.cy.ts • 1 flaky test • B2C

View Output Video

Test		Artifacts
Checkout flow > Mobile > should checkout with a registered user		Output Screenshots

  ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test		Artifacts
SSR > should render homepage		Output Screenshots
SSR > should render PLP		Output Screenshots
SSR > should render PDP		Output Screenshots

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[SherwinVarghese]

@Matejk00 I believe the review comments are addressed, awaiting approval and merge

Thanks

[vigneshkrish8691]

Feature lib changes i am ok with it.