Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mini cart stuck with value 0 #17681

Draft
wants to merge 4 commits into
base: develop-6.3.x
Choose a base branch
from
Draft

fix: mini cart stuck with value 0 #17681

wants to merge 4 commits into from

Conversation

FollowTheFlo
Copy link
Contributor

@FollowTheFlo FollowTheFlo commented Jul 25, 2023 •
edited
Loading

add totalUnitCount param in cart related endpoints
It fixes 'item count' in Mini cart, saved-cart-list, saved-cart-details

@FollowTheFlo FollowTheFlo requested a review from a team as a code owner July 25, 2023 23:34
@github-actions github-actions bot marked this pull request as draft July 25, 2023 23:34
@FollowTheFlo FollowTheFlo marked this pull request as ready for review July 26, 2023 20:24
@github-actions github-actions bot marked this pull request as draft July 26, 2023 20:25
@FollowTheFlo FollowTheFlo marked this pull request as ready for review July 26, 2023 21:10
@github-actions github-actions bot marked this pull request as draft July 26, 2023 21:36
@kimhw0630
Copy link
Contributor

The code looks fine to me..
e2e was failing due to ASM(B2C) and Account checkout (B2C)
I tried to test in S7 but it seems the server has a problem so I couldn't test it.( getting 400 when trying to add a product to the cart.. tried both above code change and without change)

kimhw0630
kimhw0630 previously approved these changes Jul 28, 2023
View reviewed changes
@FollowTheFlo FollowTheFlo changed the base branch from develop-6.3.x to develop-6.4.x August 1, 2023 16:58
@FollowTheFlo FollowTheFlo dismissed kimhw0630’s stale review August 1, 2023 16:58

The base branch was changed.

@FollowTheFlo FollowTheFlo changed the base branch from develop-6.4.x to develop-6.3.x August 1, 2023 16:59
@FollowTheFlo FollowTheFlo mentioned this pull request Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimhw0630 kimhw0630 kimhw0630 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FollowTheFlo @kimhw0630