fix: change attribute binding to property binding in GenericLink #17684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matejk00
approved these changes
Jul 26, 2023
3 flaky tests on run #41103 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| SSR > should render homepage |
Output
Screenshots
|
|
| SSR > should render PLP |
Output
Screenshots
|
|
| SSR > should render PDP |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://jira.tools.sap/browse/CXSPA-3978
Changed attribute binding to property binding for target property in link html element in GenericLinkComponent.
Appears that in a case of usage of routerLink directive attribute binding of target property might not work as expected. Angular routerLink directive is designed to handle navigation and it takes precedence over the "target" attribute.
This change was introduced in https://github.com/SAP/spartacus/pull/15770/files#diff-be88e447f5abfc2f491bd2620e288d65bdae23c59931bd397a3376bf97bb426f and related to "Enabling strict mode for storefrontlib" so seems like that change was introduced only to avoid errors in template after strict mode enabling.
So i changed it back to [target] with a fallback to "_self" if target was not specified.