Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: product image normalizer now properly checks for gallery index #17690

Merged
merged 13 commits into from
Jul 31, 2023
Merged

fix: product image normalizer now properly checks for gallery index #17690

merged 13 commits into from
Jul 31, 2023

Conversation

znikola
Copy link
Contributor

@znikola znikola commented Jul 27, 2023

@znikola znikola requested a review from a team as a code owner July 27, 2023 09:48
@github-actions github-actions bot marked this pull request as draft July 27, 2023 09:48
@znikola znikola marked this pull request as ready for review July 27, 2023 09:49
@github-actions github-actions bot marked this pull request as draft July 27, 2023 10:22
@bgambocjaviniar bgambocjaviniar marked this pull request as ready for review July 27, 2023 16:11
@github-actions github-actions bot marked this pull request as draft July 27, 2023 18:33
@znikola znikola marked this pull request as ready for review July 28, 2023 07:13
@github-actions github-actions bot marked this pull request as draft July 28, 2023 07:13
@znikola znikola marked this pull request as ready for review July 28, 2023 07:14
@github-actions github-actions bot marked this pull request as draft July 28, 2023 07:15
@znikola znikola marked this pull request as ready for review July 28, 2023 07:25
@cypress
Copy link

cypress bot commented Jul 28, 2023 •
edited
Loading

3 flaky tests on run #41158 ↗︎

0 119 2 0 Flakiness 3

Details:

Merge b927361 into a1232df...
Project: spartacus Commit: 42d7209fdc ℹ️
Status: Passed Duration: 08:24 💡
Started: Jul 31, 2023 8:29 PM Ended: Jul 31, 2023 8:38 PM
Flakiness  cypress/e2e/ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test Artifacts
SSR > should render homepage Output Screenshots
SSR > should render PLP Output Screenshots
SSR > should render PDP Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions github-actions bot marked this pull request as draft July 28, 2023 07:58
@znikola znikola marked this pull request as ready for review July 28, 2023 07:59
@github-actions github-actions bot marked this pull request as draft July 28, 2023 13:44
bgambocjaviniar added a commit that referenced this pull request Jul 28, 2023
@bgambocjaviniar
taken changes from #17690
82b7ab1
@bgambocjaviniar bgambocjaviniar marked this pull request as ready for review July 31, 2023 05:27
@github-actions github-actions bot marked this pull request as draft July 31, 2023 05:28
@bgambocjaviniar bgambocjaviniar marked this pull request as ready for review July 31, 2023 13:26
@github-actions github-actions bot marked this pull request as draft July 31, 2023 13:48
@bgambocjaviniar bgambocjaviniar marked this pull request as ready for review July 31, 2023 14:45
@github-actions github-actions bot marked this pull request as draft July 31, 2023 15:06
@bgambocjaviniar bgambocjaviniar marked this pull request as ready for review July 31, 2023 15:27
@github-actions github-actions bot marked this pull request as draft July 31, 2023 15:46
@bgambocjaviniar bgambocjaviniar marked this pull request as ready for review July 31, 2023 16:15
@github-actions github-actions bot marked this pull request as draft July 31, 2023 16:41
@bgambocjaviniar bgambocjaviniar marked this pull request as ready for review July 31, 2023 20:14
bgambocjaviniar
bgambocjaviniar approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@bgambocjaviniar bgambocjaviniar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bgambocjaviniar bgambocjaviniar merged commit 155e04f into develop-6.4.x Jul 31, 2023
22 checks passed
@bgambocjaviniar bgambocjaviniar deleted the fix/CXSPA-4181 branch July 31, 2023 21:47
@SherwinVarghese SherwinVarghese mentioned this pull request Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgambocjaviniar bgambocjaviniar bgambocjaviniar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@znikola @bgambocjaviniar