feat: add hostedFields pattern#2 #17744
Merged
+910
−247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FollowTheFlo
changed the title
5 flaky tests on run #41366 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Assisted Service Module > Apparel Site > should fetch products in a category based on the emulated user's authentication |
Output
Screenshots
|
|
regression/variants/apparel-checkout-flow.core-e2e.cy.ts • 1 flaky test • B2C
| Test | Artifacts | |
|---|---|---|
| Apparel - checkout flow > Mobile > should perform checkout with a registered user |
Output
Screenshots
|
|
ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR
| Test | Artifacts | |
|---|---|---|
| SSR > should render homepage |
Output
Screenshots
|
|
| SSR > should render PLP |
Output
Screenshots
|
|
| SSR > should render PDP |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
FollowTheFlo
commented
Sep 12, 2023
There was a problem hiding this comment.
This service is a duplicate of
spartacus/integration-libs/opf/checkout/core/services/opf-resource-loader.service.ts
It will be handled later in CXSPA-4714. I attempted to put this service in a facade but hit some prob.
rmch91
reviewed
Sep 19, 2023
rmch91
reviewed
Sep 19, 2023
...libs/opf/base/root/components/opf-payment-verification/opf-payment-verification.component.ts
Outdated
Show resolved
Hide resolved
…if cpnt & service
FollowTheFlo
commented
Sep 20, 2023
| @@ -43,17 +45,25 @@ export class OccOpfPaymentAdapter implements OpfPaymentAdapter { | |||
| protected config: OpfConfig | |||
| ) {} | |||
|
|
|||
| header: { [name: string]: string } = { | |||
There was a problem hiding this comment.
The header situation is part of CXSPA-4688 that will be merged soon. You can ignore. You won't be able to test it without it.
rmch91
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CXSPA-3879
1- from Verification Page (the existing one), add new logic to extract 'afterRedirectScriptFlag' param from URL.
2- call after-redirections-scripts GET request
3- load dynamic script from its response
4- create global function 'submitCompleteRedirect' and 'getRedirectParams' that will be called by dynamic script from step3