Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CXINT-2321 and CXINT-2322 (#17766) #17766

Merged
merged 10 commits into from
Aug 24, 2023
Merged

Conversation

SherwinVarghese
Copy link
Contributor

@SherwinVarghese SherwinVarghese commented Aug 17, 2023

E2ES pasing

Screenshot 2023-08-17 at 5 19 27 PM

Unit tests passing

=============================== Coverage summary ===============================
Statements   : 92.7% ( 89/96 )
Branches     : 85.71% ( 36/42 )
Functions    : 89.47% ( 34/38 )
Lines        : 92.47% ( 86/93 )
================================================================================

@SherwinVarghese SherwinVarghese requested a review from a team as a code owner August 17, 2023 11:52
@github-actions github-actions bot marked this pull request as draft August 17, 2023 11:52
@SherwinVarghese SherwinVarghese self-assigned this Aug 17, 2023
@Matejk00 Matejk00 marked this pull request as ready for review August 17, 2023 12:02
@github-actions github-actions bot marked this pull request as draft August 17, 2023 12:03
Copy link
Contributor

@Matejk00 Matejk00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SherwinVarghese SherwinVarghese marked this pull request as ready for review August 17, 2023 17:26
@cypress
Copy link

cypress bot commented Aug 17, 2023

5 flaky tests on run #41296 ↗︎

0 119 2 0 Flakiness 5

Details:

Merge 645513f into 4b7e907...
Project: spartacus Commit: ead472c5ed ℹ️
Status: Passed Duration: 07:14 💡
Started: Aug 24, 2023 5:41 AM Ended: Aug 24, 2023 5:49 AM
Flakiness  regression/asm/asm.deeplink.core-e2e.cy.ts • 1 flaky test • B2C

View Output Video

Test Artifacts
Assisted Service Module > Customer Support Agent - Emulation&deeplink > should emulate customer and navigate to saved cart with deeplink before agent login (CXSPA-3263) Output Screenshots
Flakiness  b2b/regression/asm/asm.core-e2e.cy.ts • 1 flaky test • B2B

View Output Video

Test Artifacts
B2B - Assisted Service Module > Powertools Site > should fetch cost centers based on the emulated user's role Output Screenshots
Flakiness  ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test Artifacts
SSR > should render homepage Output Screenshots
SSR > should render PLP Output Screenshots
SSR > should render PDP Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions github-actions bot marked this pull request as draft August 21, 2023 09:04
@SherwinVarghese SherwinVarghese marked this pull request as ready for review August 21, 2023 09:13
@github-actions github-actions bot marked this pull request as draft August 21, 2023 09:37
@SherwinVarghese SherwinVarghese marked this pull request as ready for review August 21, 2023 11:20
@SherwinVarghese SherwinVarghese requested a review from a team August 23, 2023 09:49
@SherwinVarghese SherwinVarghese requested review from a team as code owners August 23, 2023 09:49
@github-actions github-actions bot marked this pull request as draft August 23, 2023 09:49
@SherwinVarghese SherwinVarghese marked this pull request as ready for review August 23, 2023 09:51
@github-actions github-actions bot marked this pull request as draft August 23, 2023 10:14
@Matejk00 Matejk00 marked this pull request as ready for review August 23, 2023 12:11
@github-actions github-actions bot marked this pull request as draft August 23, 2023 12:35
@Matejk00 Matejk00 marked this pull request as ready for review August 23, 2023 12:36
@github-actions github-actions bot marked this pull request as draft August 23, 2023 13:05
@Matejk00 Matejk00 marked this pull request as ready for review August 23, 2023 13:06
@github-actions github-actions bot marked this pull request as draft August 23, 2023 13:29
@Matejk00 Matejk00 marked this pull request as ready for review August 23, 2023 14:14
@github-actions github-actions bot marked this pull request as draft August 23, 2023 14:36
@SherwinVarghese SherwinVarghese marked this pull request as ready for review August 23, 2023 16:00
@github-actions github-actions bot marked this pull request as draft August 23, 2023 16:24
@SherwinVarghese SherwinVarghese marked this pull request as ready for review August 23, 2023 17:01
@github-actions github-actions bot marked this pull request as draft August 23, 2023 17:22
@SherwinVarghese SherwinVarghese marked this pull request as ready for review August 24, 2023 05:27
@SherwinVarghese SherwinVarghese changed the title CXINT-2321 and CXINT-2322 fixes fix: CXINT-2321 and CXINT-2322 fixes (#17766) Aug 24, 2023
@SherwinVarghese SherwinVarghese merged commit 88c1de5 into develop-6.4.x Aug 24, 2023
22 checks passed
@SherwinVarghese SherwinVarghese deleted the bugfix/CXINT-2321 branch August 24, 2023 08:32
@SherwinVarghese SherwinVarghese changed the title fix: CXINT-2321 and CXINT-2322 fixes (#17766) fix: CXINT-2321 and CXINT-2322 (#17766) Aug 24, 2023
@SherwinVarghese SherwinVarghese restored the bugfix/CXINT-2321 branch September 14, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants