Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Customer360 main branch(CXSPA-700) #17809

Merged
merged 207 commits into from
Oct 18, 2023
Merged

feat: Customer360 main branch(CXSPA-700) #17809

merged 207 commits into from
Oct 18, 2023

Conversation

kimhw0630
Copy link
Contributor

@kimhw0630 kimhw0630 commented Aug 31, 2023

hakwookim and others added 30 commits October 13, 2022 10:31
…nt. Some styles to make modal flexible to its content
* add navigation to customer 360 dialog

* remove unnecessary styling

* Asm360Overview route navigations close the modal properly.
Lint fix using prettier:fix

Co-authored-by: Paige Barron <[email protected]>
* Adding ASM Customer 360 configs for page size; not used yet however

* Storing Google Maps API key in ASM configuration instead of hardcoded in component:

* Updating Customer Overview SCSS and some of the tab SCSS
* Refactoring AsmCustomerTable so that all logic is out of the data model fragments and into the component itself

* AsmCustomerTable needs to link to certain pages

* WIP: Refactoring AsmCustomerListing component to have logic separate from its data. Search function is missing

* WIP:
360 modal is not created statically; tabs are created dynamically via configuration. Data is passed through Injectables - a CustomerContextSource and Customer360SectionConfig.
Moving potential 360 sections into their own components folder.

* Creating SupportTickets and ProductReviews components and deleting Feedback component

* Tab name config should be a translation key, not just a configurable string

* WIP: Implementing mock HTTP request/response for the 360 customer modal. Using NgRX to implement fetching the data. Have some questions on what data is supposed to be sent back by the backend/what is needed for the FE.

* WIP: Maps section uses mock ASM 360 response

* WIP: Lint fix and cleanup. Still need to properly implement extending the data layer
…will use the CMS mapping system to load components by their name. Currently supporting Overview and Profile components
* WIP: Refactoring section components by wrapping them around another component so we can manipulate their providers so they can get the data they need

* Separating OCC-specific implementation of Customer 360 by 1) not specifying request nor response data types 2) using replaceable services to handle transforming requests and responses. Creating Asm360Service facade

* prettier fix
* Destroying subscriptions for Asm 360 section components

* Using the SectionContext to pass navigate events upward to the Customer 360 component so the modal can be closed properly

* yarn prettier:fix
@kimhw0630 kimhw0630 temporarily deployed to dev October 6, 2023 14:14 — with GitHub Actions Inactive
@kimhw0630 kimhw0630 temporarily deployed to dev October 6, 2023 18:38 — with GitHub Actions Inactive
@Platonn Platonn temporarily deployed to dev October 10, 2023 14:20 — with GitHub Actions Inactive
@kimhw0630 kimhw0630 temporarily deployed to dev October 11, 2023 14:49 — with GitHub Actions Inactive
@kimhw0630 kimhw0630 marked this pull request as ready for review October 11, 2023 14:50
@kimhw0630 kimhw0630 temporarily deployed to dev October 12, 2023 11:35 — with GitHub Actions Inactive
@github-actions github-actions bot marked this pull request as draft October 12, 2023 11:35
@kimhw0630 kimhw0630 marked this pull request as ready for review October 12, 2023 13:20
@github-actions github-actions bot marked this pull request as draft October 12, 2023 13:53
@kimhw0630 kimhw0630 temporarily deployed to dev October 12, 2023 15:50 — with GitHub Actions Inactive
@kimhw0630 kimhw0630 marked this pull request as ready for review October 12, 2023 17:15
Platonn
Platonn previously approved these changes Oct 13, 2023
@kimhw0630 kimhw0630 temporarily deployed to dev October 17, 2023 19:31 — with GitHub Actions Inactive
@kimhw0630 kimhw0630 marked this pull request as ready for review October 17, 2023 20:37
@kimhw0630 kimhw0630 merged commit ac5b4d4 into develop-6.6.x Oct 18, 2023
28 checks passed
@kimhw0630 kimhw0630 deleted the epic/CXSPA-700 branch October 18, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants