-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Customer360 main branch(CXSPA-700) #17809
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sent component data
…s pin depending on selected store.
…cation to the store
…nt. Some styles to make modal flexible to its content
… UI but not used for Map tab
…ble ui components.
…customer-360 template and module
* add navigation to customer 360 dialog * remove unnecessary styling * Asm360Overview route navigations close the modal properly. Lint fix using prettier:fix Co-authored-by: Paige Barron <[email protected]>
* Adding ASM Customer 360 configs for page size; not used yet however * Storing Google Maps API key in ASM configuration instead of hardcoded in component: * Updating Customer Overview SCSS and some of the tab SCSS
Co-authored-by: Hakwoo Kim <[email protected]>
* Refactoring AsmCustomerTable so that all logic is out of the data model fragments and into the component itself * AsmCustomerTable needs to link to certain pages * WIP: Refactoring AsmCustomerListing component to have logic separate from its data. Search function is missing * WIP: 360 modal is not created statically; tabs are created dynamically via configuration. Data is passed through Injectables - a CustomerContextSource and Customer360SectionConfig. Moving potential 360 sections into their own components folder. * Creating SupportTickets and ProductReviews components and deleting Feedback component * Tab name config should be a translation key, not just a configurable string * WIP: Implementing mock HTTP request/response for the 360 customer modal. Using NgRX to implement fetching the data. Have some questions on what data is supposed to be sent back by the backend/what is needed for the FE. * WIP: Maps section uses mock ASM 360 response * WIP: Lint fix and cleanup. Still need to properly implement extending the data layer
…will use the CMS mapping system to load components by their name. Currently supporting Overview and Profile components
* WIP: Refactoring section components by wrapping them around another component so we can manipulate their providers so they can get the data they need * Separating OCC-specific implementation of Customer 360 by 1) not specifying request nor response data types 2) using replaceable services to handle transforming requests and responses. Creating Asm360Service facade * prettier fix
Co-authored-by: Hakwoo Kim <[email protected]>
* Destroying subscriptions for Asm 360 section components * Using the SectionContext to pass navigate events upward to the Customer 360 component so the modal can be closed properly * yarn prettier:fix
Co-authored-by: Hakwoo Kim <[email protected]>
…les (#17934) Co-authored-by: Hakwoo Kim <[email protected]>
Platonn
previously approved these changes
Oct 13, 2023
Platonn
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://jira.tools.sap/browse/CXSPA-700