Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: As a customer, I want to view and update my preferred notification channels #17843
base: develop-6.7.x
Are you sure you want to change the base?
feat: As a customer, I want to view and update my preferred notification channels #17843
Changes from 4 commits
73d66d8
eda046a
3aaebae
f86aa98
ffd2a17
47e8f9b
4135a20
8dd9b10
5abb88b
a36c3f0
562a124
70eb5c2
1b3eeac
c827cb5
9eed9e2
352025f
3a9acd3
3e1b125
3fc180e
979710c
430e520
996641f
5260493
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use
protected
instead ofprivate
to make this easier for users to extend.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modified as suggestion.Only after CDC/CDP changing cms config and introduce `newNotificationPreference' in the future, it will be displayed on SPA UI. That's why there is no e2e test. But we already have a ticket to track it.
https://jira.tools.sap/browse/CXSPA-4475