Feat: my account v2 (holidays) #18348
Conversation
…into feature/CXSPA-4442
As a customer, I want to view and update my preferred notification channels
format the code and other changes from code review comments
…into feature/CXSPA-4442
add cms config
@scarai-sap it will be @morganm58 taking over the CSS review, as he is the Spartacus Theme Owner. |
feature-libs/user/profile/styles/my-account-v2/_my-account-v2-email.scss
Outdated
Show resolved
Hide resolved
| .myaccount-password-label { | ||
| @include type(); | ||
| min-width: 7.5rem; | ||
| padding: 0 1.2rem 0 0; |
There was a problem hiding this comment.
Substitute padding-left and padding-right for padding-inline-start and padding-inline-start. We need these for directionality to work.
padding-top: 0
padding-inline-end: 1.2rem
padding-bottom: 0
padding-inline-start: 0
|
|
||
| form { | ||
| label { | ||
| padding-bottom: 0.75rem !important; |
There was a problem hiding this comment.
Avoid using !important. Can you make the scss more specific so you won't need to use !important.
| } | ||
|
|
||
| .consent-details { | ||
| margin: 0 0 0 2.815rem; |
There was a problem hiding this comment.
Substitute margin-left and margin-right for margin-inline-start and margin-inline-start. We need these for directionality to work.
padding-top: 0
padding-inline-end: 0
padding-bottom: 0
padding-inline-start: 2.815rem
| } | ||
|
|
||
| .custom-switch { | ||
| margin: 0 0 0 -2.25rem; |
|
|
||
| %cx-my-account-v2-notification-preference { | ||
| .np-content-center { | ||
| -ms-flex-pack: center !important; |
| %cx-my-account-v2-notification-preference { | ||
| .np-content-center { | ||
| -ms-flex-pack: center !important; | ||
| justify-content: center !important; |
There was a problem hiding this comment.
Avoid using !important for all instances.
|
@morganm58 , all comments fixed |
scarai-sap
requested review from
morganm58,
developpeurweb,
scarai-sap and
Platonn
…AP/spartacus into feature/my-account-v2-holidays
No description provided.