GHAS. Fix Insecure randomness #19398
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
giancorderoortiz
changed the title
kpawelczak
reviewed
Oct 22, 2024
| @@ -85,7 +85,9 @@ export class MultiCartService implements MultiCartFacade { | |||
| * Simple random temp cart id generator | |||
| */ | |||
| protected generateTempCartId(): string { | |||
| const pseudoUuid = Math.random().toString(36).substring(2, 11); | |||
| const array = new Uint32Array(1); | |||
| window.crypto.getRandomValues(array); | |||
There was a problem hiding this comment.
I would be careful with window as it could potentially break the SSR rendering process.
There was a problem hiding this comment.
The function is triggered when a new cart is created, which is unlikely to occur during the rendering process. However, it is recommended to check if the window object exists before using it.
There was a problem hiding this comment.
as per @Platonn comment I've switched window with globalThis.
There was a problem hiding this comment.
Reverted globalThis.crypto as it didn't work in SSR.
spartacus
|
||||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
CXSPA-8659_randomness
|
| Run status |
|
| Run duration | 11m 53s |
| Commit |
|
| Committer | Giancarlo Cordero Ortiz |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/SAP/spartacus/security/code-scanning/49
To fix the problem, we need to replace the use of
Math.random()with a cryptographically secure random number generator. In a browser environment, we can usecrypto.getRandomValuesto generate secure random values. This method provides a cryptographically secure way to generate random numbers.We will:
cryptomodule.Math.random()call withcrypto.getRandomValuesto generate a secure random value.Suggested fixes powered by Copilot Autofix. Review carefully before merging.