Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(a11y): improve My Account payment-details/address-book components readability support #19451

Merged
merged 11 commits into from
Nov 5, 2024
Merged

feat(a11y): improve My Account payment-details/address-book components readability support #19451

merged 11 commits into from
Nov 5, 2024

Conversation

uroslates
Copy link
Contributor

@uroslates uroslates commented Oct 28, 2024 •
edited
Loading

@uroslates uroslates requested review from a team as code owners October 28, 2024 11:55
@github-actions github-actions bot marked this pull request as draft October 28, 2024 11:55
@uroslates uroslates marked this pull request as ready for review October 28, 2024 12:24
@cypress Cypress
Copy link

cypress bot commented Oct 28, 2024 •
edited
Loading

spartacus    Run #45633

Run Properties:  status check passed Passed #45633  •  git commit ebbb6836f9 ℹ️: Merge c4618a6abdc4edac95be47d7b7175c9794108715 into 4259cfd252d3ad72eceac480657b...
Project spartacus
Branch Review feature/CXSPA-8195
Run status status check passed Passed #45633
Run duration 12m 30s
Commit git commit ebbb6836f9 ℹ️: Merge c4618a6abdc4edac95be47d7b7175c9794108715 into 4259cfd252d3ad72eceac480657b...
Committer Uros Lates
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@github-actions github-actions bot marked this pull request as draft October 31, 2024 13:40
@uroslates uroslates marked this pull request as ready for review October 31, 2024 14:15
@developpeurweb
Copy link
Contributor

@uroslates the combination of aria-label + aria-describedby provides the expected narration. Just a couple of adjustments please for both, Payments and Addresses:

  1. Please remove role="application", you probably meant presentation, but even that one is not needed, if I remove the role attribute completely the information still gets narrated properly.
  2. You will have to generate differentiated IDs for each container, currently, if a user has more than two payment methods and addresses the content of the first card is always narrated for the rest of the cards.

8195 payment first container gets read for all - also remove role application

8195 addresses have same id for all

@github-actions github-actions bot marked this pull request as draft October 31, 2024 18:08
@uroslates uroslates marked this pull request as ready for review October 31, 2024 18:17
@uroslates
Copy link
Contributor Author

After conversation with Miguel we decided to use role application and combination of aria-label+aria-describedby (with dynamic id). This combination vocalises both aria-labels and children's content.

@developpeurweb
Copy link
Contributor

@uroslates I've tested this with JAWS on my end and it's all good.
Let's just wait for a developer to review the code before merging. Thanks.

Pio-Bar
Pio-Bar previously approved these changes Nov 4, 2024
View reviewed changes
@github-actions github-actions bot marked this pull request as draft November 4, 2024 08:58
Zeyber
Zeyber previously approved these changes Nov 4, 2024
View reviewed changes
@uroslates uroslates dismissed stale reviews from Zeyber and Pio-Bar via 182ab84 November 4, 2024 09:26
@uroslates uroslates marked this pull request as ready for review November 4, 2024 13:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft November 4, 2024 13:03
@uroslates uroslates marked this pull request as ready for review November 5, 2024 10:25
@uroslates uroslates merged commit 4847222 into develop Nov 5, 2024
28 checks passed
@uroslates uroslates deleted the feature/CXSPA-8195 branch November 5, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeyber Zeyber Zeyber approved these changes

@developpeurweb developpeurweb developpeurweb approved these changes

@Pio-Bar Pio-Bar Pio-Bar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@uroslates @developpeurweb @Zeyber @Pio-Bar @ulates-sap