-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(a11y): add a11y selected label improvements to checkout Address/PaymentMethod components #19491
Open
uroslates
wants to merge
16
commits into
develop
Choose a base branch
from
CXSPA-8041-latest
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+124
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DeliveryAddress/CheckoutPaymentMethod components
…method for checkout-delivery-address.component.ts
…method for checkout-payment-method.component.ts
This is a replica of PR #19381 (already approved) which was merged to develop and than reverted. Therefor now I'm opening a new PR here to finally get CXSPA-8041 merged. |
spartacus Run #45636
Run Properties:
|
Project |
spartacus
|
Branch Review |
CXSPA-8041-latest
|
Run status |
Passed #45636
|
Run duration | 12m 43s |
Commit |
47b1cae952 ℹ️: Merge b240ddb03d2ff65832b3d5d9c667d843ff8ff269 into 48472224295966d3b61de0836be0...
|
Committer | Uros Lates |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
4
|
Pending |
2
|
Skipped |
0
|
Passing |
125
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://jira.tools.sap/browse/CXSPA-8041