Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): do not block when nodejs install check fails #783

Merged
merged 3 commits into from
Dec 13, 2023
Merged

fix(backend): do not block when nodejs install check fails #783

merged 3 commits into from
Dec 13, 2023

Conversation

docirl
Copy link
Collaborator

@docirl docirl commented Dec 12, 2023

#780
#779

  • during the check for NodeJS installation, if none is found it should not block the wizard/panel from opening (keep existing flow the same)

@docirl docirl self-assigned this Dec 13, 2023
@rimasirich rimasirich merged commit 0b5c99b into master Dec 13, 2023
5 checks passed
@rimasirich rimasirich deleted the node-install-check branch December 13, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veredcon veredcon veredcon approved these changes

@alex-gilin alex-gilin Awaiting requested review from alex-gilin

Assignees

@docirl docirl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@docirl @veredcon @rimasirich