Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

192: Workflows #195

Merged
merged 17 commits into from
Jan 23, 2024
Merged

192: Workflows #195

merged 17 commits into from
Jan 23, 2024

Conversation

evan-scales
Copy link
Collaborator

@evan-scales evan-scales commented Jan 20, 2024

  • Created build-workflow
    • Build, publish, upload artifacts, and tests api
    • runs lint on spa, (later will be updated to run spa behavioral tests), auto formats code
  • Created release-workflow
    • Deploys SPA and API to azure whenever we bring changes to prod branch
  • Tested both workflows, see past runs

@evan-scales evan-scales linked an issue Jan 20, 2024 that may be closed by this pull request
@evan-scales
Copy link
Collaborator Author

Why the prod branch? Real world software is released on a cycle. Feature branches arn't merged to the master branch then released and deployed right away. Typically when it's time for a release changes are brought over to the release branch from master, then the app is redeployed based on the release branch. Prod will be our release branch

@jbytes1027
Copy link
Contributor

If this has never actually succeeded in running, are you sure it will actually work when the checks pass? The failing tests probably should be fixed before we merge this so we can verify it will work.

@evan-scales
Copy link
Collaborator Author

Its the linter thats failing, everything still works. Just tells us errors like'
Error: 1:8 error 'React' is defined but never used

@evan-scales
Copy link
Collaborator Author

linter errors fixed

Copy link

Tests ran successfully!

@evan-scales evan-scales marked this pull request as draft January 22, 2024 22:04
@evan-scales
Copy link
Collaborator Author

Run formatter on build-spa

@evan-scales evan-scales marked this pull request as ready for review January 23, 2024 00:55
.github/workflows/build-workflow.yml Outdated Show resolved Hide resolved
@jbytes1027
Copy link
Contributor

Be sure to stop failing pr's from being able to be merged.

@evan-scales evan-scales merged commit b800faf into main Jan 23, 2024
1 of 2 checks passed
@evan-scales evan-scales deleted the 192 branch January 23, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflows
2 participants