cube meshes with Simmetrix to create various topology combinations to… #5
Conversation
… test CGNS writer
|
These are tests for SCOREC/core PR #395. Mixed case is not working but others all run through and look good in ParaView. That does not test whether the boundary elements are written correctly though. Not quite sure how to do that yet. Also tet cases may be in an order to create a negative volume. It is a fairly easy fix (swap second and third vertex in connectivity). As I was looking around chef I also noticed some comments about some elements are set to outward normals while others are in so we may have some cleanup there but I think @jedbrown owes me instructions on what he wants in terms of face numbering so we can do that whenever it is all defined. Finally, at this point, these meshes do not have ZonalBCs written. I will update them as that gets completed though I think that is an @jrwrigh task. @cwsmith I don't see @jrwrigh, @jedbrown or @rickybalin available to assign to this submodule. I hope the github names get this message to them |
There was a problem hiding this comment.
Would you please describe how all these files are going to be used by scorec/core/phasta ctests? If they are not required for testing (i.e., inputs, 'gold'/expected outputs) or provide some provenance on how the inputs were created, then I'd prefer they not be stored in this repo.
There was a problem hiding this comment.
If this is an executable, please remove it.
There was a problem hiding this comment.
Major cleanup. Execs gone. I prefer to keep the workflow intact which is
top dir is 6 Simmetrix sms files that use the same cube.smd file. Each of those sms files and the smd file feed into 6 directories which use convert to create an mds database. It would be possible to mv have just the mds file and a couple of adapt.inp files (splitFactor 1 and splitFactor 2 or even one file and sed that) if you want to compact this down to inputs and outputs (one cgns file per geometry X number of parts).
There was a problem hiding this comment.
What does this do? Where does pcgnslib.h (Phasta Ceed CGNS library I assume) come from?
There was a problem hiding this comment.
nope. That is Parallel CGNS include file.
I will find another home for this (e.g., probably paste it into a wiki to help people learn how to add CNGS to a code. Sadly what CNGS posts on their web page docs is out of date AND they post no instructions on how to build so this file represents a couple of hours of work I did to remedy that (would have been 20 minutes if I was not learning along the way but....).
There was a problem hiding this comment.
If possible, the test commands should be builtin to scorec/core/phasta ctest.
There was a problem hiding this comment.
Yes this will come with time (and help from people who understand better than me how to do that).
|
From offline discussions: this PR will be considered a 'draft' for now and pruned of unnecessary files as work progresses. |
…a matched order to boundary elements as back door to boundary conditions in User Data where I also aded three arrays that give the ownership counts for points/coordinates, interior elements, and boundary elements.
|
@jedbrown If you want to get files from here this is the structure |
…_write after an Allgatherv
…t implemented yet
…s and have produced CGNS files with peiodicity as defined by the interface
|
I think this is all up to date and ready. |
… test CGNS writer