scons-time: add filter to tarfile extract call. #4527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.13.0b1 added a warning when the extraction filter is not specified. The filter aregument (to extract() and extractall()) was added in 3.12, but with no noise. Once the warning was added, the scons-time tests began to fail - this is a continuation of the work Red Hat did for RHEL 8 and RHEL 9 starting with Python 3.9. Supplying the filter quiets the warning, which also worked for the RHEL case. The tarfile and zipfile usage now uses a context manager (both objects can be used this way since Python 3.2 or so). Signed-off-by: Mats Wichmann <[email protected]>
mwichmann
added
the
testsuite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.13.0b1 added a warning when the extraction filter is not specified. The
filterargument (toextract()andextractall()) was added in 3.12, but with no noise. Once the warning was added, thescons-timetests began to fail - this is a continuation of the work Red Hat did for RHEL 8 and RHEL 9 starting with Python 3.9. Supplying the filter quiets the warning, which also worked for the RHEL case.The
tarfileandzipfileusage now uses a context manager (both objects can be used this way since Python 3.2 or so).This has no visible effects -
scons-timeis only used during testing. Not added to release note asbin/scons-time.pyis not part of the released SCons wheel.Contributor Checklist:
CHANGES.txt(and read theREADME.rst)