Backend/feature/user endpoint #30
Conversation
warreprovoost
requested review from
Gerwoud,
JarneClauw,
AronBuzogany and
JibrilExe
warreprovoost
added
backend
There was a problem hiding this comment.
To stay consistent with other endpoints, don't capitalize your response keys. In your case Message -> message. Also, next to only a message or only data. In each case provide at least the following 3 fields: message, url and data. Except for delete where there is no data
# Conflicts: # backend/project/__init__.py # backend/project/__main__.py # backend/project/endpoints/index/OpenAPI_Object.json # backend/project/models/users.py # backend/tests/endpoints/conftest.py # backend/tests/models/conftest.py # backend/tests/models/course_test.py
backend/project/endpoints/users.py
Outdated
| if user is None: | ||
| return {"message": "User not found!"}, 404 | ||
|
|
||
| user_js = { |
There was a problem hiding this comment.
You don't need this extra step, you can pass user as value of "data" field
There was a problem hiding this comment.
The tests fail if i don't do this
There was a problem hiding this comment.
That's because you register your endpoints to the API. You should still register them to the blueprint. Calling Api(bp) already sets the appropriate middleware etc.
There was a problem hiding this comment.
the result of user = db.session.get(userModel, user_id) is a User(...) object, how is this supposed to go into the json?
There was a problem hiding this comment.
See current version of development this is being done all the time. This is the reason you had to make your model a dataclass.
backend/project/endpoints/users.py
Outdated
|
|
||
| # Save the changes to the database | ||
| db.session.commit() | ||
| user_js = { |
|
@warreprovoost resolve branch conflicts before asking for a review |
# Conflicts: # backend/project/__init__.py
@AronBuzogany my bad did not see it, should be good now |
User endpoint created
The signature of
URL.create(...)should be the same for everyone.Pycharm added the minimal version in the requirements, is this okay?