Homework day 2 - 11/28/17 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comfort: 3/5
Completness: 2.5/3?
I had a tough time with the password login. I could get multiple prompts to display if the entered password was wrong, but then was having a hard time getting the subsequent entries to be validated correctly. Was also getting stuck in infinite loops of the alert displaying. Some instances of code I was trying would seem to throw alerts out of order. My current code works...as long as you enter your password right the first try.
The 99 bottles of beer song seemed fairly straight forward and felt easier than the other 2 parts. I seem to repeat myself more than the solution code though but I feel that my code is more readable and easier to see what is going on. Of course that is my opinion based on my limited knowledge