-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue3549 adding test output to deploy task #3564
base: main
Are you sure you want to change the base?
Conversation
Thanks for the contribution! Before we can merge this, we need @jtruit to sign the Salesforce Inc. Contributor License Agreement. |
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Sean Truitt <s***@j***.edu>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated. |
Hey @davidmreed we talked about this PR a while back in the SFXD discord. Any changes you would recommend? |
@jtruit My apologies for slow responses. The one thing that I'd love to add, at a glance, is a test that validates the content of the exported JUnit. |
Fixing comment
# Conflicts: # AUTHORS.rst # cumulusci/tasks/salesforce/Deploy.py # cumulusci/tasks/salesforce/tests/test_Deploy.py
@jtruit I apologize for the poor action on this PR, for which I'm responsible I'm no longer on the CumulusCI team, however. @jstvz or @jkasturi-sf, are you able to get this PR in the queue for final review? |
Hi @jstvz is there anything I need to do in order to get this reviewed? |
Deploy to Salesforce does not create a test output. This would add a .json and .xml output of the test results after deploy.