@W-17440435: Filter default records during INSERT for SELECT action #3865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lakshmi2506
requested changes
Dec 27, 2024
There was a problem hiding this comment.
@aditya-balachander can you please check the behavior for the records in lookup with the default records, because it will replaced with an empty string with the present behavior I guess.
|
@lakshmi2506 since I cannot complete the WI, have assigned the WI to @mjawadtp and closing this WI since the new approach is entirely different |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
W-17440435
Changes:
select_post_processwhere any default records (defined inhardcoded_default_declarations.py) present in the local SQL are removed if nouser_filteris provided.Reason for the condition: The default records are included during selection from the target org when a
user_filteris provided. Therefore, default records should only be excluded from the local SQL when they are also excluded during the selection process, which occurs only when nouser_filteris specified.