Add and Test Clang-tidy

[haytham918]

Addressing the issue in #1060. Added clang-tidy check on files inside "libopenage" directory, focusing on "clang-analyzer", "bugprone", "concurrency", and "performance" issues. @heinezen

[haytham918]

I think make checkall doesn't work for your workflow because it didn't detect installed clang-tidy

[heinezen]

@TheJJ kevin needs clang-tidy to be installed

[heinezen]

@haytham918 You should add clang-tidy as a sanity check dependency in https://github.com/SFTtech/openage/blob/master/doc/building.md#dependencies

[haytham918]

@heinezen Thank you for the notice. I have updated it accordingly.

[heinezen]

@TheJJ Did you add clang-tidy already?

[haytham918]

@heinezen @TheJJ , I hope you are doing well with the new year :), any updates on this request?

[heinezen]

@haytham918 Happy new year! I'm still waiting for @TheJJ to add clang-tidy to the CI machine.