fix generate_database action #479
Conversation
|
Getting a username/password error. Not sure if that's because this is a pull requests or not. |
Likely yes, I think there are secrets either in this repo or in the binary repo that control how we can push to the binary repo. I don't know if pull requests can access this information. |
.github/workflows/gen-db.yml
Outdated
| # More details on trigger events: https://docs.github.com/en/actions/reference/events-that-trigger-workflows | ||
| # More details on trigger events: | ||
| # https://docs.github.com/en/actions/reference/events-that-trigger-workflows | ||
| pull_request: # added for testing |
There was a problem hiding this comment.
We should not do this on a pull_request, as this action essentially builds the binary file for purposes of the website. That should only be done when we are ready to push a change, not when someone opens a pull request.
There was a problem hiding this comment.
I am pretty sure I added this here just so it would run on this PR. in order to test the script.
| source_file: 'SIMPLE.db' | ||
| source_file: 'SIMPLE.sqlite' |
There was a problem hiding this comment.
Once this is merged, we will need to go to the binary repo and delete the old db file to avoid confusion.
|
Recommend avoiding |
I disagree. This is exactly the use case for |
|
Waiting on astrodbtoolkit/astrodb_utils#42 |
Re-adds the
generate_database.pyscript to generate the database file for the SIMPLE-binary repo.Changed database name from
.dbto.sqlite.