Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use check_spectrum_plottable from astrodb_utils #548

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

kelle
Copy link
Collaborator

@kelle kelle commented Jul 31, 2024

The spectrum_plottable function has been incorporated into astrodb_utils and should not be in this repo anymore. The changes made there necissated some changes in the ingest_spectrum function.

@kelle kelle requested a review from dr-rodriguez July 31, 2024 21:47
),
@pytest.mark.parametrize(
"test_input, message",
[
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a note, if you want to prevent auto-formatters from reformatting text (for example if you prefer something more compact even if it's not Black/ruff/darker-standard) you can preface the block with # fmt: off and then end it with # fmt: on

Copy link
Collaborator

@dr-rodriguez dr-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kelle kelle merged commit 3e70973 into SIMPLE-AstroDB:main Aug 2, 2024
1 check passed
@kelle kelle deleted the remove-plotting branch August 2, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants