RFC: Allow .url.txt files only inside src/mods/ #273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Usage? |
|
See https://github.com/SKCraft/Launcher/wiki/Creating-Modpacks#download-from-a-custom-url Expect you do not need the original file locally. Exactly what do you described here: #268 (comment) Do you mean how to use is on travis? Which commands? |
|
Yes, indeed. |
|
If it had worked yet, yes. |
|
Active still? PR needs merging 🎉🎉🎉 |
|
It just redownloads every time? Also syntax style is off from Oracle’s |
Yes, a good developer may add a cache but i'm unable to integrate it.
No idea. I'm not familiar with java ... |
This was
linked to
issues
Dec 24, 2020
Nydid
approved these changes
Jan 23, 2021
|
Superseded by 67f3fc1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an proof of concept for #268 .
Instead ignoring the hashsum completely, this build will follow the link inside the
.url.txt. This has two benefits:This is backwards compatible. If the orginal file is still there, the old behavior is used.
TODO:
If a non dev will test this, get creator-tools-2.0.2-SNAPSHOT-all.jar.zip and provide some feedback please.