Fix MinGW build #68
Open
Fix MinGW build #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Pospelove, thanks for your contribution. Atm we are focusing on other parts of the engine and MinGW is nothing we currently support. Nevertheless, I'll see to integrate what you provided when we got some resources available. |
|
Thanks for your reply @Luke1410. It will be nice to see this integrated, in fact, this is the only thing that breaks MinGW support. I've tested my changes and it seems they do not break anything. Connecting, packet delivery works. Btw if anything is wrong with this patch, I could fix that. I am not aware of your coding standards, so pull requested as it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! This PR fixes MinGW build by patching code in some places and adding functions that missing on MinGW (inet_pton/inet_ntop). Currently, third-party implementations used, but I could rewrite these functions if it's needed. Looking forward to your review.
See microsoft/vcpkg#18358