Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of crate config to get version #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgrojo
Copy link
Contributor

@mgrojo mgrojo commented Feb 11, 2023

This allows changing the version only in the alire.toml file.

@SMerrony
Copy link
Owner

Although I appreciate the DRY aspect of this PR, it feels "inside-out" to me...
I don't want the application source to depend on the build system (which could change).
It would make more sense to me if Alire could pick up the version from the application source.

@mgrojo
Copy link
Contributor Author

mgrojo commented Feb 16, 2023

This is the solution proposed by Alire, so you have a centralized definition of the software version. What they also recommend, it's adding the generated config/ files to git, so the project can still be built without Alire, provided that the user adds the dependencies themselves and set GPR_PROJECT_PATH accordingly. I should have done also that part, but, in any case, I don't know if that would address your concern.

In any case, you're free to disregard this pull request, of course. I just couldn't resist proposing it after seeing your comment in the version constant 😃

Regarding Alire picking up the version from application source, I think it would be more cumbersome than the current approach. They have a general mechanism for crate configuration which also solves the problem of centralized version, but it's useful for other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants