Add supernode for comparing a literal string #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…string comparions. For the nil case in the string comparison, we store `nil` in a local static field to avoid type restrictions of the DSL. Signed-off-by: Stefan Marr <[email protected]> # Conflicts: # src/trufflesom/src/trufflesom/compiler/ParserAst.java
This node inlines the argument and field reading and does the string equal. There's theoretical an early abort for non-object fields. Though, we don't have those in our benchmarks. Well, perhaps uninitialized fields. Though, the structure of the lookup, and caching makes that tricky. Not sure it's worth optimizing that. Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Should be ensured in the caller. Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
smarr
force-pushed
the
supernode/string-equal
branch
from
7351fb5
to
3d74296
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #185, and extracts the supernodes for the comparison with literal strings:
"someString" = varandvar = "someString"self