Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix/#99] add logic fix #102

Merged
merged 4 commits into from
Jan 24, 2025
Merged

[Hotfix/#99] add logic fix #102

merged 4 commits into from
Jan 24, 2025

Conversation

imtaejugkim
Copy link
Collaborator

โœ… ๐—–๐—ต๐—ฒ๐—ฐ๐—ธ-๐—Ÿ๐—ถ๐˜€๐˜

  • mergeํ•  ๋ธŒ๋žœ์น˜์˜ ์œ„์น˜๋ฅผ ํ™•์ธํ•ด ์ฃผ์„ธ์š”(mainโŒ/developโญ•)
  • ๋ฆฌ๋ทฐ๊ฐ€ ํ•„์š”ํ•œ ๊ฒฝ์šฐ ๋ฆฌ๋ทฐ์–ด๋ฅผ ์ง€์ •ํ•ด ์ฃผ์„ธ์š”
  • ๋ฆฌ๋ทฐ๋Š” (์•„์ง ๋ฏธ์ •)์— ์ง„ํ–‰๋ฉ๋‹ˆ๋‹ค.
  • P1 ๋‹จ๊ณ„์˜ ๋ฆฌ๋ทฐ๋Š” (์•„์ง ๋ฏธ์ •)๊นŒ์ง€ ๋ฐ˜์˜ํ•ฉ๋‹ˆ๋‹ค.
  • Approve๋œ PR์€ assigner๊ฐ€ ๋จธ์ง€ํ•˜๊ณ , ์ˆ˜์ • ์š”์ฒญ์ด ์˜จ ๊ฒฝ์šฐ ์ˆ˜์ • ํ›„ ๋‹ค์‹œ push๋ฅผ ํ•ฉ๋‹ˆ๋‹ค.

๐Ÿ“Œ ๐—œ๐˜€๐˜€๐˜‚๐—ฒ๐˜€

๐Ÿ“Ž๐—ช๐—ผ๐—ฟ๐—ธ ๐——๐—ฒ๐˜€๐—ฐ๐—ฟ๐—ถ๐—ฝ๐˜๐—ถ๐—ผ๐—ป

  • add schedule ํŠ•๊น€ ์ˆ˜์ •
  • todo ๋กœ์ง ์˜ค๋ฅ˜ ์ˆ˜์ •

๐Ÿ“ท ๐—ฆ๐—ฐ๐—ฟ๐—ฒ๐—ฒ๐—ป๐˜€๐—ต๐—ผ๐˜

๐Ÿ’ฌ ๐—ง๐—ผ ๐—ฅ๐—ฒ๐˜ƒ๐—ถ๐—ฒ๐˜„๐—ฒ๐—ฟ๐˜€

๊ณ ์ƒํ–ˆ๋‹ค ์–˜๋“ค์•„ ๋ฐฉ์–ด๋จน์œผ๋Ÿฌ ๊ฐ€์ž

@imtaejugkim imtaejugkim added ๐Ÿคขํƒœ์ •๐Ÿคข ๐Ÿ˜ฎ [HOTFIX] issue๋‚˜ QA์—์„œ ๋ฌธ์˜๋œ ๊ธ‰ํ•œ ๋ฒ„๊ทธ ๋ฐ ์˜ค๋ฅ˜ ํ•ด๊ฒฐ ๐ŸŒ€์„œ๋ฒ„ํ†ต์‹  ์„œ๋ฒ„ํ†ต์‹  ์ง„ํ–‰ํ•ฉ๋‹ˆ๋‹ค labels Jan 24, 2025
@imtaejugkim imtaejugkim self-assigned this Jan 24, 2025
Copy link
Collaborator

@hyoeunjoo hyoeunjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํƒœ์ •์–ธ๋‹ˆ ์ง„์งœ ์งฑ์ด์—์š”ใ…  ์ง„์งœ ์•„~~๊นŒ๋ถ€ํ„ฐ๋๋Š”๋ฐ... ์†์ƒํ•œ ๋งˆ์Œ์€ ๋„ˆ๋ฌด ์ž˜ ์ดํ•ด๋˜์ง€๋งŒ... ์ตœ์„ ์„ ๋‹คํ–ˆ์œผ๋‹ˆ ๋ฏธ๋ จ์€ ์—†๋Š”๊ฑฐ๊ฐ™์•„์š”์ž‰ ใ…‹ใ…‹~
์ง„์งœ 2์ฃผ๋™์•ˆ ๊ณ ์ƒ๋งŽ์•˜๋‹ค ๊ฐœ๋ฐœ์ฒœ์žฌํƒœ์ •์–ธ๋‹ˆ!

Copy link
Collaborator

@hwidung hwidung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์˜ค๋น  ๋„ˆ๋ฌด ๊ณ ์ƒํ–‡์ ธใ…•ใ…•ใ…•ใ…•ใ…•ใ…•ใ…•ใ…•ใ…• ์–ต๊นŒ STOP

@hyoeunjoo hyoeunjoo merged commit 18c882c into develop Jan 24, 2025
1 check passed
@hyoeunjoo hyoeunjoo deleted the hotfix/#99-add-logic-fix branch January 24, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐ŸŒ€์„œ๋ฒ„ํ†ต์‹  ์„œ๋ฒ„ํ†ต์‹  ์ง„ํ–‰ํ•ฉ๋‹ˆ๋‹ค ๐Ÿ˜ฎ [HOTFIX] issue๋‚˜ QA์—์„œ ๋ฌธ์˜๋œ ๊ธ‰ํ•œ ๋ฒ„๊ทธ ๋ฐ ์˜ค๋ฅ˜ ํ•ด๊ฒฐ ๐Ÿคขํƒœ์ •๐Ÿคข
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Hotfix] ํˆฌ๋‘ ์ถ”๊ฐ€, ์ผ์ • ์ถ”๊ฐ€ ์˜ค๋ฅ˜ ์ˆ˜์ •
3 participants