Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/#59] user info update api #76

Merged
merged 16 commits into from
Jan 23, 2025
Merged

Conversation

hwidung
Copy link
Collaborator

@hwidung hwidung commented Jan 23, 2025

โœ… ๐—–๐—ต๐—ฒ๐—ฐ๐—ธ-๐—Ÿ๐—ถ๐˜€๐˜

  • mergeํ•  ๋ธŒ๋žœ์น˜์˜ ์œ„์น˜๋ฅผ ํ™•์ธํ•ด ์ฃผ์„ธ์š”(mainโŒ/developโญ•)
  • ๋ฆฌ๋ทฐ๊ฐ€ ํ•„์š”ํ•œ ๊ฒฝ์šฐ ๋ฆฌ๋ทฐ์–ด๋ฅผ ์ง€์ •ํ•ด ์ฃผ์„ธ์š”
  • ๋ฆฌ๋ทฐ๋Š” (์•„์ง ๋ฏธ์ •)์— ์ง„ํ–‰๋ฉ๋‹ˆ๋‹ค.
  • P1 ๋‹จ๊ณ„์˜ ๋ฆฌ๋ทฐ๋Š” (์•„์ง ๋ฏธ์ •)๊นŒ์ง€ ๋ฐ˜์˜ํ•ฉ๋‹ˆ๋‹ค.
  • Approve๋œ PR์€ assigner๊ฐ€ ๋จธ์ง€ํ•˜๊ณ , ์ˆ˜์ • ์š”์ฒญ์ด ์˜จ ๊ฒฝ์šฐ ์ˆ˜์ • ํ›„ ๋‹ค์‹œ push๋ฅผ ํ•ฉ๋‹ˆ๋‹ค.

๐Ÿ“Œ ๐—œ๐˜€๐˜€๐˜‚๐—ฒ๐˜€

๐Ÿ“Ž๐—ช๐—ผ๐—ฟ๐—ธ ๐——๐—ฒ๐˜€๐—ฐ๐—ฟ๐—ถ๐—ฝ๐˜๐—ถ๐—ผ๐—ป

  • ์˜จ๋ณด๋”ฉ์—์„œ์˜ ์œ ์ € ์ •๋ณด๋ฅผ ์„œ๋ฒ„๋กœ ๋ณด๋‚ด๋Š” ์ž‘์—…
  • ๋””ํดํŠธ ๊ฐ’ ์‚ฝ์ž…

๐Ÿ“ท ๐—ฆ๐—ฐ๐—ฟ๐—ฒ๐—ฒ๐—ป๐˜€๐—ต๐—ผ๐˜

์ฐฐ์นต!
image

๐Ÿ’ฌ ๐—ง๐—ผ ๐—ฅ๐—ฒ๐˜ƒ๐—ถ๐—ฒ๐˜„๐—ฒ๐—ฟ๐˜€

@hwidung hwidung self-assigned this Jan 23, 2025
@hwidung hwidung added ๐Ÿถํœ˜์›๐Ÿถ โญ [FEAT] ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ๊ตฌํ˜„ ๐ŸŒ€์„œ๋ฒ„ํ†ต์‹  ์„œ๋ฒ„ํ†ต์‹  ์ง„ํ–‰ํ•ฉ๋‹ˆ๋‹ค labels Jan 23, 2025
@hyoeunjoo hyoeunjoo requested review from imtaejugkim and hyoeunjoo and removed request for imtaejugkim January 23, 2025 16:46
โ€ฆ-update-api

# Conflicts:
#	app/src/main/java/org/memento/di/DataSourceModule.kt
#	app/src/main/java/org/memento/di/RepositoryModule.kt
#	app/src/main/java/org/memento/di/ServiceModule.kt
Copy link
Collaborator

@imtaejugkim imtaejugkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwidung hwidung merged commit 061707f into develop Jan 23, 2025
1 check passed
@hwidung hwidung deleted the feat/#59-user-info-update-api branch January 23, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
โญ [FEAT] ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ๊ตฌํ˜„ ๐ŸŒ€์„œ๋ฒ„ํ†ต์‹  ์„œ๋ฒ„ํ†ต์‹  ์ง„ํ–‰ํ•ฉ๋‹ˆ๋‹ค ๐Ÿถํœ˜์›๐Ÿถ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] ์‚ฌ์šฉ์ž ์ •๋ณด ์—…๋ฐ์ดํŠธ API
3 participants