Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Center navbar header content, fix navbar header image size & improve how navbar determines height #291

Merged
merged 2 commits into from
Aug 15, 2024
Merged

fix: Center navbar header content, fix navbar header image size & improve how navbar determines height #291

merged 2 commits into from
Aug 15, 2024

Conversation

CharlRitterDev
Copy link
Contributor

Center navbar header content, fix navbar header image size & improve how navbar determines height

Description

Center navbar header content, fix navbar header image size & improve how navbar determines height

Issue

https://spandigital.atlassian.net/browse/PRSDM-6146

Screenshots

Refer to video below

Checklist before merging

  • Did you test your changes locally?
  • Did you update the CHANGELOG?
  • Is the documentation updated for this change? (If Required)

@CharlRitterDev CharlRitterDev requested a review from a team as a code owner August 14, 2024 15:41
@CharlRitterDev
Copy link
Contributor Author

Screen.Recording.2024-08-14.at.17.30.20.mov

@CharlRitterDev CharlRitterDev changed the title Center navbar header content, fix navbar header image size & improve how navbar determines height fix: Center navbar header content, fix navbar header image size & improve how navbar determines height Aug 14, 2024
@julianbyte
Copy link
Contributor

LGTM, tested locally

Zalaras
Zalaras approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@Zalaras Zalaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not tested locally

@CharlRitterDev CharlRitterDev merged commit f731f7e into develop Aug 15, 2024
1 check passed
@CharlRitterDev CharlRitterDev deleted the PRSDM-6146 branch August 15, 2024 09:15
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianbyte julianbyte julianbyte approved these changes

@Zalaras Zalaras Zalaras approved these changes

@richardwooding richardwooding Awaiting requested review from richardwooding richardwooding is a code owner automatically assigned from SPANDigital/span-presidium-dev

@Quantumplate Quantumplate Awaiting requested review from Quantumplate Quantumplate is a code owner automatically assigned from SPANDigital/span-presidium-dev

@zelrestemmet zelrestemmet Awaiting requested review from zelrestemmet zelrestemmet is a code owner automatically assigned from SPANDigital/span-presidium-dev

@Gerrit-van-Niekerk Gerrit-van-Niekerk Awaiting requested review from Gerrit-van-Niekerk Gerrit-van-Niekerk is a code owner automatically assigned from SPANDigital/span-presidium-dev

@mpilo-khathwane mpilo-khathwane Awaiting requested review from mpilo-khathwane mpilo-khathwane is a code owner automatically assigned from SPANDigital/span-presidium-dev

@kmorake kmorake Awaiting requested review from kmorake kmorake is a code owner automatically assigned from SPANDigital/span-presidium-dev

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CharlRitterDev @julianbyte @Zalaras