Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add models for QoS and an AnalyticsListener to gather session load times #596

Merged
merged 12 commits into from
Jun 21, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Jun 19, 2024

Pull request

Description

This PR adds the models needed for QoS (session, event, error, message). It also adds a custom AnalyticsListener to measure the load times of a media, and report them in the QoS session.

Changes made

  • Add QoS specific models.
  • Add a new AnalyticsListener on PillarboxExoPlayer to observe media load times.
  • Include the library version in the BuildConfig.VERSION_NAME field.
  • Add some unit tests.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

StaehliJ and others added 6 commits June 18, 2024 17:23
This commit introduces unit tests for the following QoS classes:
- `QoSError`
- `QoSSession`
- `QoSSessionTimings`

These tests ensure the correct behavior of these classes and provide a safety net for future development.
@MGaetan89 MGaetan89 self-assigned this Jun 19, 2024
@MGaetan89 MGaetan89 added this to the QoS milestone Jun 19, 2024
@MGaetan89 MGaetan89 force-pushed the 574-gather-metrics-for-qos branch from f53739c to 3601503 Compare June 19, 2024 15:39
Copy link

github-actions bot commented Jun 19, 2024

Code Coverage

Overall Project 52.37% -0.54% 🟢
Files changed 85.73% 🟢

Module Coverage
:pillarbox-player 53.3% -1.09% 🟢
Files
Module File Coverage
:pillarbox-player QoSSessionTimings.kt 100% 🟢
QoSSession.kt 100% 🟢
QoSError.kt 96.92% -3.08% 🟢
QoSSessionAnalyticsListener.kt 91.09% -8.91% 🟢
PillarboxMediaSource.kt 87.47% -6.59% 🟢
PillarboxExoPlayer.kt 83.37% 🟢
PillarboxMediaSourceFactory.kt 54.6% 🟢
QoSEvent.kt 0% 🟢
QoSMessage.kt 0% 🟢

pillarbox-player/build.gradle.kts Outdated Show resolved Hide resolved
pillarbox-player/build.gradle.kts Outdated Show resolved Hide resolved
@MGaetan89 MGaetan89 merged commit 4e0288d into qos Jun 21, 2024
10 checks passed
@MGaetan89 MGaetan89 deleted the 574-gather-metrics-for-qos branch June 21, 2024 09:17
@MGaetan89 MGaetan89 linked an issue Jun 24, 2024 that may be closed by this pull request
StaehliJ added a commit that referenced this pull request Jun 26, 2024
MGaetan89 added a commit that referenced this pull request Jul 9, 2024
MGaetan89 added a commit that referenced this pull request Jul 11, 2024
MGaetan89 added a commit that referenced this pull request Jul 17, 2024
MGaetan89 added a commit that referenced this pull request Jul 29, 2024
MGaetan89 added a commit that referenced this pull request Jul 30, 2024
MGaetan89 added a commit that referenced this pull request Aug 12, 2024
MGaetan89 added a commit that referenced this pull request Aug 13, 2024
MGaetan89 added a commit that referenced this pull request Aug 20, 2024
StaehliJ added a commit that referenced this pull request Aug 28, 2024
StaehliJ added a commit that referenced this pull request Sep 11, 2024
MGaetan89 added a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Gather session metrics for QoS
2 participants