-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add models for QoS and an AnalyticsListener
to gather session load times
#596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces unit tests for the following QoS classes: - `QoSError` - `QoSSession` - `QoSSessionTimings` These tests ensure the correct behavior of these classes and provide a safety net for future development.
MGaetan89
force-pushed
the
574-gather-metrics-for-qos
branch
from
June 19, 2024 15:39
f53739c
to
3601503
Compare
Code Coverage
Files
|
StaehliJ
requested changes
Jun 20, 2024
StaehliJ
approved these changes
Jun 21, 2024
StaehliJ
added a commit
that referenced
this pull request
Jun 26, 2024
…times (#596) Co-authored-by: Joaquim Stähli <[email protected]>
6 tasks
MGaetan89
added a commit
that referenced
this pull request
Jul 9, 2024
…times (#596) Co-authored-by: Joaquim Stähli <[email protected]>
MGaetan89
added a commit
that referenced
this pull request
Jul 11, 2024
…times (#596) Co-authored-by: Joaquim Stähli <[email protected]>
MGaetan89
added a commit
that referenced
this pull request
Jul 17, 2024
…times (#596) Co-authored-by: Joaquim Stähli <[email protected]>
MGaetan89
added a commit
that referenced
this pull request
Jul 29, 2024
…times (#596) Co-authored-by: Joaquim Stähli <[email protected]>
MGaetan89
added a commit
that referenced
this pull request
Jul 30, 2024
…times (#596) Co-authored-by: Joaquim Stähli <[email protected]>
MGaetan89
added a commit
that referenced
this pull request
Aug 12, 2024
…times (#596) Co-authored-by: Joaquim Stähli <[email protected]>
MGaetan89
added a commit
that referenced
this pull request
Aug 13, 2024
…times (#596) Co-authored-by: Joaquim Stähli <[email protected]>
MGaetan89
added a commit
that referenced
this pull request
Aug 20, 2024
…times (#596) Co-authored-by: Joaquim Stähli <[email protected]>
StaehliJ
added a commit
that referenced
this pull request
Aug 28, 2024
…times (#596) Co-authored-by: Joaquim Stähli <[email protected]>
StaehliJ
added a commit
that referenced
this pull request
Sep 11, 2024
…times (#596) Co-authored-by: Joaquim Stähli <[email protected]>
MGaetan89
added a commit
that referenced
this pull request
Sep 12, 2024
…times (#596) Co-authored-by: Joaquim Stähli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR adds the models needed for QoS (session, event, error, message). It also adds a custom
AnalyticsListener
to measure the load times of a media, and report them in the QoS session.Changes made
AnalyticsListener
onPillarboxExoPlayer
to observe media load times.BuildConfig.VERSION_NAME
field.Checklist
main
branch.